From: Daniel Walker <dwalker@fifo99.com>
To: Greg Kroah-Hartman <greg@kroah.com>
Cc: Brian Swetland <swetland@google.com>,
linux-kernel@vger.kernel.org, Daniel Walker <dwalker@fifo99.com>
Subject: [PATCH 4/6] staging: android: binder: add enum usage in function arguments
Date: Fri, 12 Jun 2009 11:51:16 -0700 [thread overview]
Message-ID: <1244832678-30329-4-git-send-email-dwalker@fifo99.com> (raw)
In-Reply-To: <1244832678-30329-3-git-send-email-dwalker@fifo99.com>
Declare the binder_deferred_state enum, and use the new enum
for one of the binder_defer_work function arguments. This
should keep the argument within the confines of the enum
instead of the whole int range.
Signed-off-by: Daniel Walker <dwalker@fifo99.com>
---
drivers/staging/android/binder.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index ec86808..30a5ea5 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -243,7 +243,7 @@ struct binder_buffer {
uint8_t data[0];
};
-enum {
+enum binder_deferred_state {
BINDER_DEFERRED_PUT_FILES = 0x01,
BINDER_DEFERRED_FLUSH = 0x02,
BINDER_DEFERRED_RELEASE = 0x04,
@@ -326,7 +326,8 @@ struct binder_transaction {
uid_t sender_euid;
};
-static void binder_defer_work(struct binder_proc *proc, int defer);
+static void
+binder_defer_work(struct binder_proc *proc, enum binder_deferred_state defer);
/*
* copied from get_unused_fd_flags
@@ -3073,7 +3074,8 @@ static void binder_deferred_func(struct work_struct *work)
}
static DECLARE_WORK(binder_deferred_work, binder_deferred_func);
-static void binder_defer_work(struct binder_proc *proc, int defer)
+static void
+binder_defer_work(struct binder_proc *proc, enum binder_deferred_state defer)
{
mutex_lock(&binder_deferred_lock);
proc->deferred_work |= defer;
--
1.5.4.3
next prev parent reply other threads:[~2009-06-12 18:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 18:51 [PATCH 1/6] staging: android: binder: Remove some funny && usage Daniel Walker
2009-06-12 18:51 ` [PATCH 2/6] staging: android: binder: move debugging mask into a macro Daniel Walker
2009-06-12 18:51 ` [PATCH 3/6] staging: android: binder: remove a predefine Daniel Walker
2009-06-12 18:51 ` Daniel Walker [this message]
2009-06-12 18:51 ` [PATCH 5/6] staging: android: binder: global variable cleanup Daniel Walker
2009-06-12 18:51 ` [PATCH 6/6] staging: android: binder: clean up for all the stat statments Daniel Walker
2009-06-16 20:46 ` [PATCH 1/6] staging: android: binder: Remove some funny && usage Jeremy Fitzhardinge
2009-06-17 14:37 ` Daniel Walker
2009-06-17 15:28 ` Jeremy Fitzhardinge
2009-06-17 16:08 ` Daniel Walker
2009-06-17 16:31 ` Jeremy Fitzhardinge
2009-06-17 21:26 ` Arve Hjønnevåg
2009-06-17 21:31 ` Daniel Walker
2009-06-19 19:20 ` Brian Swetland
2009-06-19 22:53 ` Daniel Walker
2009-06-20 0:13 ` Arve Hjønnevåg
2009-06-20 0:49 ` Daniel Walker
2009-06-20 18:48 ` Christoph Hellwig
2009-06-21 12:09 ` Marcel Holtmann
2009-06-25 4:09 ` Dianne Hackborn
2009-06-25 10:14 ` Marcel Holtmann
2009-06-25 11:34 ` Alan Cox
2009-06-25 13:24 ` Daniel Walker
2009-06-27 2:20 ` GeunSik Lim
2009-06-20 1:26 ` GeunSik Lim
2009-06-24 13:13 ` Daniel Walker
2009-06-24 22:14 ` Brian Swetland
2009-06-24 22:49 ` Daniel Walker
2009-06-24 23:05 ` Brian Swetland
2009-06-24 23:29 ` Daniel Walker
2009-06-24 23:37 ` Brian Swetland
2009-06-25 0:01 ` Linus Walleij
2009-06-25 0:20 ` Daniel Walker
2009-06-25 8:15 ` Alan Cox
2009-06-25 9:56 ` Marcel Holtmann
2009-06-17 21:38 ` Jeremy Fitzhardinge
2009-06-19 14:59 ` Pavel Machek
2009-06-19 15:08 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244832678-30329-4-git-send-email-dwalker@fifo99.com \
--to=dwalker@fifo99.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome