From: Mike Frysinger <vapier@gentoo.org>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] ramfs: ignore tmpfs options when we emulate it
Date: Sat, 13 Jun 2009 02:02:00 -0400 [thread overview]
Message-ID: <1244872920-13511-1-git-send-email-vapier@gentoo.org> (raw)
On systems where CONFIG_SHMEM is disabled, mounting tmpfs filesystems can
fail when tmpfs options are used. This is because tmpfs creates a small
wrapper around ramfs which rejects unknown options, and ramfs itself only
supports a tiny subset of what tmpfs supports. This makes it pretty hard
to use the same userspace systems across different configuration systems.
As such, ramfs should ignore the tmpfs options when tmpfs is merely a
wrapper around ramfs.
This used to work before commit c3b1b1cbf0 as previously, ramfs would
ignore all options. But now, we get:
ramfs: bad mount option: size=10M
mount: mounting mdev on /dev failed: Invalid argument
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
another option might be to restore the previous behavior where ramfs simply
ignored all unknown mount options ...
fs/ramfs/inode.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/fs/ramfs/inode.c b/fs/ramfs/inode.c
index 3a6b193..57a797c 100644
--- a/fs/ramfs/inode.c
+++ b/fs/ramfs/inode.c
@@ -203,6 +203,16 @@ static int ramfs_parse_options(char *data, struct ramfs_mount_opts *opts)
opts->mode = option & S_IALLUGO;
break;
default:
+#ifndef CONFIG_SHMEM
+ /* If tmpfs is using us to emulate it, ignore its options */
+ if (!strncmp(p, "gid=", 4) ||
+ !strncmp(p, "mpol=", 5) ||
+ !strncmp(p, "nr_blocks=", 10) ||
+ !strncmp(p, "nr_inodes=", 10) ||
+ !strncmp(p, "size=", 5) ||
+ !strncmp(p, "uid=", 4))
+ continue;
+#endif
printk(KERN_ERR "ramfs: bad mount option: %s\n", p);
return -EINVAL;
}
--
1.6.3.1
next reply other threads:[~2009-06-13 6:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 6:02 Mike Frysinger [this message]
2009-06-13 14:15 ` Hugh Dickins
2009-06-13 14:20 ` Mike Frysinger
2009-06-13 18:51 ` Matt Mackall
2009-06-14 10:01 ` Wu Fengguang
2009-06-14 10:20 ` Mike Frysinger
2009-06-14 10:43 ` Wu Fengguang
2009-06-14 10:39 ` Hugh Dickins
2009-06-14 10:48 ` Wu Fengguang
2009-06-14 16:00 ` Matt Mackall
2009-06-14 21:56 ` [PATCH] ramfs: ignore unknown mount options Hugh Dickins
2009-06-14 10:42 ` [PATCH] ramfs: ignore tmpfs options when we emulate it Wu Fengguang
2009-06-14 10:46 ` Mike Frysinger
2009-06-14 11:14 ` Wu Fengguang
2009-06-14 11:26 ` Mike Frysinger
2009-06-14 11:49 ` Wu Fengguang
2009-06-14 11:58 ` Mike Frysinger
2009-06-14 12:14 ` Wu Fengguang
2009-06-14 12:16 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244872920-13511-1-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®