From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org,
Linux-MIPS <linux-mips@linux-mips.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ralf Baechle <ralf@linux-mips.org>, Wu Zhangjin <wuzj@lemote.com>
Subject: [PATCH] kmemtrace:fix undeclared 'PAGE_SIZE' via asm/page.h
Date: Sun, 14 Jun 2009 13:54:23 +0800 [thread overview]
Message-ID: <1244958863-28899-1-git-send-email-wuzhangjin@gmail.com> (raw)
From: Wu Zhangjin <wuzj@lemote.com>
when compiling linux-mips with kmemtrace enabled, this error will be
there:
include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
a function)
I checked the source code and found trace_seq.h used PAGE_SIZE but not
include the relative header file, so, fix it via adding the header file
<asm/page.h>
this error will not be triggered in linux-x86 for there is a
<asm/page.h> header file included in a certain header file. but which
not means <asm/page.h> is not needed in trace_seq.h
Signed-off-by: Wu Zhangjin <wuzj@lemote.com>
---
include/linux/trace_seq.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
index c68bccb..c134dd1 100644
--- a/include/linux/trace_seq.h
+++ b/include/linux/trace_seq.h
@@ -3,6 +3,8 @@
#include <linux/fs.h>
+#include <asm/page.h>
+
/*
* Trace sequences are used to allow a function to call several other functions
* to create a string of data to use (up to a max of PAGE_SIZE.
--
1.6.0.4
next reply other threads:[~2009-06-14 5:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-14 5:54 Wu Zhangjin [this message]
2009-06-14 5:59 ` Pekka Enberg
2009-06-14 6:17 ` Wu Zhangjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244958863-28899-1-git-send-email-wuzhangjin@gmail.com \
--to=wuzhangjin@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rostedt@goodmis.org \
--cc=wuzj@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®