From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Justin Tee <justin.tee@broadcom.com>
Cc: kernel@collabora.com, kernel-janitors@vger.kernel.org,
James Smart <jsmart2021@gmail.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: correct size for cmdwqe/rspwqe for memset
Date: Mon, 4 Mar 2024 11:18:43 +0100 [thread overview]
Message-ID: <1244daaf-4b02-4dd1-915d-0e50ef638b6a@collabora.com> (raw)
In-Reply-To: <20240301144434.2809483-1-usama.anjum@collabora.com>
Il 01/03/24 15:44, Muhammad Usama Anjum ha scritto:
> The cmdwqe and rspwqe are of type lpfc_wqe128. They should be memset
> with the same type.
>
> Fixes: 61910d6a5243 ("scsi: lpfc: SLI path split: Refactor CT paths")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> drivers/scsi/lpfc/lpfc_bsg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
> index d80e6e81053b0..8caf54aa20391 100644
> --- a/drivers/scsi/lpfc/lpfc_bsg.c
> +++ b/drivers/scsi/lpfc/lpfc_bsg.c
> @@ -3169,10 +3169,10 @@ lpfc_bsg_diag_loopback_run(struct bsg_job *job)
> }
>
> cmdwqe = &cmdiocbq->wqe;
> - memset(cmdwqe, 0, sizeof(union lpfc_wqe));
> + memset(cmdwqe, 0, sizeof(union lpfc_wqe128));
memset(cmdwqe, 0, sizeof(*cmdwqe));
Cheers,
Angelo
prev parent reply other threads:[~2024-03-04 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 14:44 Muhammad Usama Anjum
2024-03-01 16:39 ` Christophe JAILLET
2024-03-01 18:59 ` Justin Tee
2024-03-04 8:44 ` Muhammad Usama Anjum
2024-03-04 10:18 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244daaf-4b02-4dd1-915d-0e50ef638b6a@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=jsmart2021@gmail.com \
--cc=justin.tee@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®