From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757392AbZFOLKw (ORCPT ); Mon, 15 Jun 2009 07:10:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752577AbZFOLKp (ORCPT ); Mon, 15 Jun 2009 07:10:45 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:50073 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752132AbZFOLKo (ORCPT ); Mon, 15 Jun 2009 07:10:44 -0400 Subject: Re: [BUGFIX][PATCH] memcg: fix page_cgroup fatal error in FLATMEM v2 From: Pekka Enberg To: balbir@linux.vnet.ibm.com Cc: KAMEZAWA Hiroyuki , Li Zefan , linux-kernel@vger.kernel.org, mingo@elte.hu, hannes@cmpxchg.org, torvalds@linux-foundation.org, yinghai@kernel.org, "linux-mm@kvack.org" In-Reply-To: <4A3270FE.4090602@linux.vnet.ibm.com> References: <4A31C258.2050404@cn.fujitsu.com> <20090612115501.df12a457.kamezawa.hiroyu@jp.fujitsu.com> <20090612124408.721ba2ae.kamezawa.hiroyu@jp.fujitsu.com> <4A31D326.3030206@cn.fujitsu.com> <20090612143429.76ef2357.kamezawa.hiroyu@jp.fujitsu.com> <84144f020906112321x9912476sb42b5d811741e646@mail.gmail.com> <20090612152922.0e7d1221.kamezawa.hiroyu@jp.fujitsu.com> <4A3270FE.4090602@linux.vnet.ibm.com> Date: Mon, 15 Jun 2009 14:10:45 +0300 Message-Id: <1245064245.23207.28.camel@penberg-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-Mailer: Evolution 2.24.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2009-06-12 at 20:45 +0530, Balbir Singh wrote: > > From: KAMEZAWA Hiroyuki > > > > Now, SLAB is configured in very early stage and it can be used in > > init routine now. > > > > But replacing alloc_bootmem() in FLAT/DISCONTIGMEM's page_cgroup() > > initialization breaks the allocation, now. > > (Works well in SPARSEMEM case...it supports MEMORY_HOTPLUG and > > size of page_cgroup is in reasonable size (< 1 << MAX_ORDER.) > > > > This patch revive FLATMEM+memory cgroup by using alloc_bootmem. > > > > In future, > > We stop to support FLATMEM (if no users) or rewrite codes for flatmem > > completely.But this will adds more messy codes and overheads. > > > > Changelog: v1->v2 > > - fixed typos. > > > > Acked-by: Pekka Enberg > > Tested-by: Li Zefan > > Reported-by: Li Zefan > > Signed-off-by: KAMEZAWA Hiroyuki > > I see you've responded already, Thanks! > > The diff is a bit confusing, was Pekka's patch already integrated, in my version > of mmotm, I don't see the alloc_pages_node() change in my source base. Yes, my patch hit mainline on Thursday or so and this patch is now in as well. Pekka