Re: [PATCH] clocksource: setup mult_orig in clocksource_enable()

[john stultz <johnstul@us.ibm.com>]

On Tue, 2009-06-16 at 05:04 +0900, Paul Mundt wrote:
> On Mon, Jun 15, 2009 at 12:08:37PM -0700, john stultz wrote:
> > On Sun, 2009-06-14 at 19:20 +0900, Magnus Damm wrote:
> > > On Sat, Jun 13, 2009 at 8:56 AM, john stultz<johnstul@us.ibm.com> wrote:
> > > > On Thu, 2009-06-11 at 14:51 +0900, Magnus Damm wrote:
> > > >> I can't think of any way that would work. The clock frequency can be
> > > >> changed while the clock is disabled. And we can only know the rate
> > > >> after enabling the clock, see these lines from include/linux/clk.h:
> > > >>
> > > >> /**
> > > >>  * clk_get_rate - obtain the current clock rate (in Hz) for a clock source.
> > > >>  *              This is only valid once the clock source has been enabled.
> > > >>  * @clk: clock source
> > > >>  */
> > > >> unsigned long clk_get_rate(struct clk *clk);
> > > >
> > > > Hrmm.. Yuck.
> > > >
> > > > Is this really expected behavior that a clk would change frequencies
> > > > between uses as a clocksource?
> > > 
> > > Yes, I think so. The clock frequency can change through cpufreq or
> > > clk_set_rate().
> > 
> > But they do not change freq (through cpufreq or anything else) after the
> > enable() call, right? That would be pretty critical. Otherwise they'd
> > need to be disqualified like we do the TSC on x86.
> > 
> This is a bit tricky, the clock needs to be able to adjust its parent
> divisors/multipliers in order to maintain its current frequency if a
> parent clock changes frequency. We do not presently prohibit a frequency
> change that deviates from the current frequency on these clocks, but
> this would be trivially handled by setting a fixed rate flag for those
> clocks. This sort of logic is necessary to block frequency changes in the
> parent clock topology that would throw the child clock's frequency out of
> sync. Note that in the general case we do not want to disable frequency
> changes on enabled clocks, enabled clocks only need to know whether they
> can handle a frequency change or not without destabilizing the system.

Any change to the freq mult value in the clocksource would be
destabilizing. So I'd advise pretty strongly to make sure that clk's
being used as clocksources cannot change frequency once they're enabled
and in use.

thanks
-john