mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: Report regulator_get() failure in virtual consumer
Date: Tue, 16 Jun 2009 10:15:55 +0100	[thread overview]
Message-ID: <1245143755.21421.95.camel@vega.slimlogic.co.uk> (raw)
In-Reply-To: <1245092461-8813-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Mon, 2009-06-15 at 20:01 +0100, Mark Brown wrote:
> The core will no longer complain so we should log an error here.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  drivers/regulator/virtual.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/regulator/virtual.c b/drivers/regulator/virtual.c
> index e7db566..e953c18 100644
> --- a/drivers/regulator/virtual.c
> +++ b/drivers/regulator/virtual.c
> @@ -285,6 +285,8 @@ static int regulator_virtual_consumer_probe(struct platform_device *pdev)
>  	drvdata->regulator = regulator_get(&pdev->dev, reg_id);
>  	if (IS_ERR(drvdata->regulator)) {
>  		ret = PTR_ERR(drvdata->regulator);
> +		dev_err(&pdev->dev, "Failed to obtain supply '%s': %d\n",
> +			reg_id, ret);
>  		goto err;
>  	}
>  

Applied.

Thanks

Liam


      reply	other threads:[~2009-06-16  9:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15 19:01 Mark Brown
2009-06-16  9:15 ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245143755.21421.95.camel@vega.slimlogic.co.uk \
    --to=lrg@slimlogic.co.uk \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®