mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Mel Gorman <mel@csn.ul.ie>, Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	torvalds@linux-foundation.org, fengguang.wu@intel.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH] kmemleak: Rename kmemleak_panic to kmemleak_stop
Date: Wed, 17 Jun 2009 16:36:59 +0100	[thread overview]
Message-ID: <1245253019.11889.55.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <1245245448.5604.31.camel@penberg-laptop>

This is to avoid the confusion created by the "panic" word.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
---

(following Pekka's suggestion)

 mm/kmemleak.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index 25e2034..c1f538e 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -251,7 +251,7 @@ static void kmemleak_disable(void);
  * recovered from. Kkmemleak will be disabled and further allocation/freeing
  * tracing no longer available.
  */
-#define kmemleak_panic(x...)	do {	\
+#define kmemleak_stop(x...)	do {	\
 	kmemleak_warn(x);		\
 	kmemleak_disable();		\
 } while (0)
@@ -467,8 +467,8 @@ static void create_object(unsigned long ptr, size_t size, int min_count,
 
 	object = kmem_cache_alloc(object_cache, gfp & GFP_KMEMLEAK_MASK);
 	if (!object) {
-		kmemleak_panic("kmemleak: Cannot allocate a kmemleak_object "
-			       "structure\n");
+		kmemleak_stop("kmemleak: Cannot allocate a kmemleak_object "
+			      "structure\n");
 		return;
 	}
 
@@ -527,8 +527,8 @@ static void create_object(unsigned long ptr, size_t size, int min_count,
 	if (node != &object->tree_node) {
 		unsigned long flags;
 
-		kmemleak_panic("kmemleak: Cannot insert 0x%lx into the object "
-			       "search tree (already existing)\n", ptr);
+		kmemleak_stop("kmemleak: Cannot insert 0x%lx into the object "
+			      "search tree (already existing)\n", ptr);
 		object = lookup_object(ptr, 1);
 		spin_lock_irqsave(&object->lock, flags);
 		dump_object_info(object);
@@ -699,7 +699,7 @@ static void log_early(int op_type, const void *ptr, size_t size,
 	struct early_log *log;
 
 	if (crt_early_log >= ARRAY_SIZE(early_log)) {
-		kmemleak_panic("kmemleak: Early log buffer exceeded\n");
+		kmemleak_stop("kmemleak: Early log buffer exceeded\n");
 		return;
 	}
 



  reply	other threads:[~2009-06-17 15:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200906162232.n5GMWRZe026963@imap1.linux-foundation.org>
     [not found] ` <20090616223649.719ea378.akpm@linux-foundation.org>
2009-06-17 11:18   ` [PATCH] pagemap: add page-types tool, fix build Ingo Molnar
2009-06-17 11:31     ` WARNING: at mm/page_alloc.c:1159 get_page_from_freelist+0x325/0x655() Ingo Molnar
2009-06-17 11:35       ` Ingo Molnar
2009-06-17 12:19         ` [PATCH] profile: Suppress warning about large allocations when profile=1 is specified Mel Gorman
2009-06-20 10:09           ` Heinz Diehl
2009-06-20 19:50             ` Mel Gorman
2009-06-20 21:48               ` Heinz Diehl
2009-06-22 11:31                 ` Mel Gorman
2009-06-22 13:50                   ` Heinz Diehl
2009-06-22 19:58                     ` Mel Gorman
2009-06-22 17:00                   ` Arnaldo Carvalho de Melo
2009-06-17 11:41       ` WARNING: at mm/page_alloc.c:1159 get_page_from_freelist+0x325/0x655() Mel Gorman
2009-06-17 12:11       ` Catalin Marinas
2009-06-17 12:28         ` Mel Gorman
2009-06-17 12:36           ` Catalin Marinas
2009-06-17 12:40             ` Mel Gorman
2009-06-17 12:52               ` [PATCH] kmemleak: Only use GFP_KERNEL|GFP_ATOMIC for the internal allocations Catalin Marinas
2009-06-17 13:01                 ` Pekka Enberg
2009-06-17 13:23                   ` Catalin Marinas
2009-06-17 13:30                     ` Pekka Enberg
2009-06-17 15:36                       ` Catalin Marinas [this message]
2009-06-17 15:37                         ` [PATCH] kmemleak: Rename kmemleak_panic to kmemleak_stop Pekka Enberg
2009-06-17 17:14                         ` Daniel Walker
2009-06-17 17:27                           ` Catalin Marinas
2009-06-17 16:39       ` WARNING: at mm/page_alloc.c:1159 get_page_from_freelist+0x325/0x655() Linus Torvalds
2009-06-17 16:52         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245253019.11889.55.camel@pc1117.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mel@csn.ul.ie \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome