From: Huang Ying <ying.huang@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [BUGFIX 2/3] crypto: Remove CRYPTO_TFM_REQ_MAY_SLEEP flag in AES-NI accelerated ecb/cbc mode
Date: Fri, 19 Jun 2009 08:55:20 +0800 [thread overview]
Message-ID: <1245372920.22246.15.camel@yhuang-dev.sh.intel.com> (raw)
In-Reply-To: <20090618114032.GB6596@gondor.apana.org.au>
On Thu, 2009-06-18 at 19:40 +0800, Herbert Xu wrote:
> On Mon, Jun 15, 2009 at 05:04:57PM +0800, Huang Ying wrote:
> > Because AES-NI instructions will touch XMM state, corresponding code
> > must be enclosed within kernel_fpu_begin/end, which used
> > preempt_disable/enable. So sleep should be prevented between
> > kernel_fpu_begin/end.
> >
> > Signed-off-by: Huang Ying <ying.huang@intel.com>
>
> I'll apply this for now. But it would be much better to allow
> sleeping in this case.
>
> Couldn't we simply move the kernel_fpu_begin/end inside the loop?
> It shouldn't be too expensive when it runs the 2nd time since it
> doesn't have to save anything, right?
I will test the performance difference.
Best Regards,
Huang Ying
prev parent reply other threads:[~2009-06-19 0:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 9:04 Huang Ying
2009-06-18 11:40 ` Herbert Xu
2009-06-19 0:55 ` Huang Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245372920.22246.15.camel@yhuang-dev.sh.intel.com \
--to=ying.huang@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®