From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Sachin Sant <sachinp@in.ibm.com>
Subject: Re: [PATCH] mm/init: cpu_hotplug_init() must be initialized before SLAB
Date: Mon, 22 Jun 2009 20:13:08 -0500 [thread overview]
Message-ID: <1245719588.17035.42.camel@mulgrave.site> (raw)
In-Reply-To: <1245717089.4017.18.camel@pasglop>
On Tue, 2009-06-23 at 10:31 +1000, Benjamin Herrenschmidt wrote:
> SLAB uses get/put_online_cpus() which use a mutex which is itself
> only initialized when cpu_hotplug_init() is called. Currently
> we hang suring boot in SLAB due to doing that too late. This
> moves the call to cpu_hotplug_init() to before mm_init() (it
> should be safe to call that early).
>
> This fixes boot with SLAB on some PowerPC machines.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> Sachin, James, do that fix the boot failures you've been seeing ?
Yes, that seems to fix it for me.
James
next prev parent reply other threads:[~2009-06-23 1:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 0:31 Benjamin Herrenschmidt
2009-06-23 1:13 ` James Bottomley [this message]
2009-06-23 2:29 ` Linus Torvalds
2009-06-23 2:59 ` Benjamin Herrenschmidt
2009-06-23 3:23 ` Benjamin Herrenschmidt
2009-06-23 3:26 ` Sachin Sant
2009-06-23 4:00 ` James Bottomley
2009-06-23 5:59 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245719588.17035.42.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=rjw@sisk.pl \
--cc=sachinp@in.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®