From: Richard Purdie <rpurdie@rpsys.net>
To: Greg KH <greg@kroah.com>
Cc: asdf@kroah.com, Guennadi Liakhovetski <lg@denx.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] LED: Reply-To: use correct name for /sys/devices/virtual/leds/ entries
Date: Thu, 25 Jun 2009 11:57:55 +0100 [thread overview]
Message-ID: <1245927475.6001.38.camel@dax.rpnet.com> (raw)
In-Reply-To: <20090624223343.GA17235@kroah.com>
On Wed, 2009-06-24 at 15:33 -0700, Greg KH wrote:
> From: Olaf Hering <olh@suse.de>
>
> This is needed to get kde-powersave to work properly on some g4
> powerbooks.
>
> From: Olaf Hering <olh@suse.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
I'm ok with this apart from:
> --- a/drivers/leds/ledtrig-default-on.c
> +++ b/drivers/leds/ledtrig-default-on.c
> @@ -23,7 +23,7 @@ static void defon_trig_activate(struct l
> }
>
> static struct led_trigger defon_led_trigger = {
> - .name = "default-on",
> + .name = "default::on",
> .activate = defon_trig_activate,
> };
which doesn't seem to match the patch description. Why does the trigger
name need to be changed?
Cheers,
Richard
--
Richard Purdie
Intel Open Source Technology Centre
next prev parent reply other threads:[~2009-06-25 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 22:33 Greg KH
2009-06-25 10:57 ` Richard Purdie [this message]
2009-06-26 2:46 ` Greg KH
2009-06-26 10:01 ` Richard Purdie
2009-06-26 20:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245927475.6001.38.camel@dax.rpnet.com \
--to=rpurdie@rpsys.net \
--cc=asdf@kroah.com \
--cc=greg@kroah.com \
--cc=lg@denx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®