From: Ben Nizette <ben@niasdigital.com>
To: "haavard.skinnemoen" <haavard.skinnemoen@atmel.com>
Cc: kernel <kernel@avr32linux.org>,
"Egtvedt, Hans-Christian" <Hans-Christian.Egtvedt@atmel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] favr32: improve touchscreen response
Date: Fri, 26 Jun 2009 17:49:37 +1000 [thread overview]
Message-ID: <1246002577.9414.62.camel@linux-51e8.site> (raw)
In-Reply-To: <1240195013.24329.38.camel@linux-51e8.site>
Hi Haavard,
This has hce's ack, any chance of getting it in .31?
Thx,
--Ben.
On Mon, 2009-04-20 at 12:36 +1000, Ben Nizette wrote:
> The ezLCD+101 board (to which an favr-32 is fitted) has a long,
> unshielded, nasty lead between the touch panel and the ads7843 touch
> controller. In order to get satisfactory response then, we need to
> employ every noise-reduction trick in the driver's arsenal. After
> extensive fiddling I've found some good settings:
>
> 1) We keep vref on all the time to dramatically reduce settling times
> (at the cost of a tiny increase in power consumption).
>
> 2) Despite 1 the settling time is still non-zero. 500uS is plenty of
> time for the signals to settle
>
> 3) Despite 1 and 2 there's still a little bit of noise around. By
> setting a pen recheck delay we make the panel feel less touchy and
> twitchy.
>
> Someone with more time and patience myself might be able to tune this
> numbers further but these settings are now perfectly acceptable for
> normal use.
>
> Tested on ezLCD+101 though should only improve response on other ezLCD+/
> favr-32 boards too.
>
> Signed-off-by: Ben Nizette <bn@niasdigital.com>
>
> ---
> arch/avr32/boards/favr-32/setup.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/avr32/boards/favr-32/setup.c b/arch/avr32/boards/favr-32/setup.c
> index 58203d1..f1152fa 100644
> --- a/arch/avr32/boards/favr-32/setup.c
> +++ b/arch/avr32/boards/favr-32/setup.c
> @@ -72,6 +72,10 @@ static struct ads7846_platform_data ads7843_data = {
> .debounce_max = 20,
> .debounce_rep = 4,
> .debounce_tol = 5,
> +
> + .keep_vref_on = true,
> + .settle_delay_usecs = 500,
> + .penirq_recheck_delay_usecs = 100,
> };
next prev parent reply other threads:[~2009-06-26 7:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 2:36 Ben Nizette
2009-04-20 3:13 ` Ben Nizette
2009-04-20 5:54 ` Hans-Christian Egtvedt
2009-06-26 7:49 ` Ben Nizette [this message]
2009-07-27 11:17 ` Haavard Skinnemoen
2009-07-29 21:39 ` Ben Nizette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246002577.9414.62.camel@linux-51e8.site \
--to=ben@niasdigital.com \
--cc=Hans-Christian.Egtvedt@atmel.com \
--cc=haavard.skinnemoen@atmel.com \
--cc=kernel@avr32linux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®