From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
Sam Ravnborg <sam@ravnborg.org>,
Boaz Harrosh <bharrosh@panasas.com>,
Benny Halevy <bhalevy@panasas.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] SCSI: userspace cannot use scsi_command_size_tbl, COMMAND_SIZE and scsi_device_type
Date: Sat, 27 Jun 2009 22:35:59 +0530 [thread overview]
Message-ID: <1246122359.32198.7.camel@hpdv5.satnam> (raw)
userspace cannot use scsi_command_size_tbl, COMMAND_SIZE
and scsi_device_type defined in kernel
fix the following 'make headers_check' warnings:
usr/include/scsi/scsi.h:159: userspace cannot call function or variable defined in the kernel
usr/include/scsi/scsi.h:285: userspace cannot call function or variable defined in the kernel
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
include/scsi/scsi.h | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
index 084478e..7ba5acf 100644
--- a/include/scsi/scsi.h
+++ b/include/scsi/scsi.h
@@ -156,9 +156,6 @@ scsi_varlen_cdb_length(const void *hdr)
return ((struct scsi_varlen_cdb_hdr *)hdr)->additional_cdb_length + 8;
}
-extern const unsigned char scsi_command_size_tbl[8];
-#define COMMAND_SIZE(opcode) scsi_command_size_tbl[((opcode) >> 5) & 7]
-
static inline unsigned
scsi_command_size(const unsigned char *cmnd)
{
@@ -166,6 +163,13 @@ scsi_command_size(const unsigned char *cmnd)
scsi_varlen_cdb_length(cmnd) : COMMAND_SIZE(cmnd[0]);
}
+#ifdef __KERNEL__
+extern const unsigned char scsi_command_size_tbl[8];
+#define COMMAND_SIZE(opcode) scsi_command_size_tbl[((opcode) >> 5) & 7]
+
+/* Returns a human-readable name for the device */
+extern const char * scsi_device_type(unsigned type);
+#endif
/*
* SCSI Architecture Model (SAM) Status codes. Taken from SAM-3 draft
* T10/1561-D Revision 4 Draft dated 7th November 2002.
@@ -281,9 +285,6 @@ enum scsi_protocol {
SCSI_PROTOCOL_UNSPEC = 0xf, /* No specific protocol */
};
-/* Returns a human-readable name for the device */
-extern const char * scsi_device_type(unsigned type);
-
/*
* standard mode-select header prepended to all mode-select commands
*/
--
1.6.0.6
next reply other threads:[~2009-06-27 17:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-27 17:05 Jaswinder Singh Rajput [this message]
2009-06-27 17:27 ` James Bottomley
2009-06-27 17:56 ` Jaswinder Singh Rajput
2009-06-27 18:28 ` Matthew Wilcox
2009-06-27 18:40 ` Jaswinder Singh Rajput
2009-06-28 13:52 ` James Bottomley
2009-06-28 14:09 ` Boaz Harrosh
2009-07-02 14:41 ` Jaswinder Singh Rajput
2009-06-28 7:56 ` Boaz Harrosh
2009-06-28 14:32 ` James Smart
2009-06-28 14:44 ` James Bottomley
2009-06-28 16:00 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246122359.32198.7.camel@hpdv5.satnam \
--to=jaswinder@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bhalevy@panasas.com \
--cc=bharrosh@panasas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®