From: Jiri Slaby <jirislaby@gmail.com>
To: sameo@linux.intel.com
Cc: drwyrm@gmail.com, laforge@openezx.org,
linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>
Subject: [PATCH] MFD: ezx-pcap, fix lock imbalance
Date: Wed, 1 Jul 2009 08:53:07 +0200 [thread overview]
Message-ID: <1246431187-23684-1-git-send-email-jirislaby@gmail.com> (raw)
There is an omitted unlock in pcap_adc_irq ISR on one fail path. Fix that.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
drivers/mfd/ezx-pcap.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
index 671a7ef..c1de4af 100644
--- a/drivers/mfd/ezx-pcap.c
+++ b/drivers/mfd/ezx-pcap.c
@@ -238,8 +238,10 @@ static irqreturn_t pcap_adc_irq(int irq, void *_pcap)
mutex_lock(&pcap->adc_mutex);
req = pcap->adc_queue[pcap->adc_head];
- if (WARN(!req, KERN_WARNING "adc irq without pending request\n"))
+ if (WARN(!req, KERN_WARNING "adc irq without pending request\n")) {
+ mutex_unlock(&pcap->adc_mutex);
return IRQ_HANDLED;
+ }
/* read requested channels results */
ezx_pcap_read(pcap, PCAP_REG_ADC, &tmp);
--
1.6.3.2
next reply other threads:[~2009-07-01 6:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 6:53 Jiri Slaby [this message]
2009-07-01 7:04 ` Daniel Ribeiro
2009-07-01 7:33 ` Jiri Slaby
2009-07-01 8:09 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246431187-23684-1-git-send-email-jirislaby@gmail.com \
--to=jirislaby@gmail.com \
--cc=drwyrm@gmail.com \
--cc=laforge@openezx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome