From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756065AbZGAOEz (ORCPT ); Wed, 1 Jul 2009 10:04:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752936AbZGAOEs (ORCPT ); Wed, 1 Jul 2009 10:04:48 -0400 Received: from hera.kernel.org ([140.211.167.34]:54561 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752068AbZGAOEr (ORCPT ); Wed, 1 Jul 2009 10:04:47 -0400 Subject: Re: [PATCH -tip RESEND] x86: mm/init.c declare check_efer() before it get used From: Jaswinder Singh Rajput To: Ingo Molnar Cc: Andrew Morton , x86 maintainers , LKML In-Reply-To: <1246450889.6940.10.camel@hpdv5.satnam> References: <1246450889.6940.10.camel@hpdv5.satnam> Content-Type: text/plain Date: Wed, 01 Jul 2009 19:34:16 +0530 Message-Id: <1246457056.6940.17.camel@hpdv5.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2009-07-01 at 17:51 +0530, Jaswinder Singh Rajput wrote: > check_efer() is already declared in asm/proto.h, so include it before using it. > > Also fix sparse warning : > > CHECK arch/x86/mm/init.c > arch/x86/mm/init.c:83:16: warning: symbol 'check_efer' was not declared. Should it be static? > > Signed-off-by: Jaswinder Singh Rajput > --- [PATCH] x86: mm/init.c declare check_efer() before it get used This sparse warning: arch/x86/mm/init.c:83:16: warning: symbol 'check_efer' was not declared. Should it be static? triggers because check_efer() is not decalared before using it. asm/proto.h includes the declaration of check_efer(), so including asm/proto.h to fix that - this also address the sparse warning. Signed-off-by: Jaswinder Singh Rajput --- arch/x86/mm/init.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index 47ce9a2..0607119 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -12,6 +12,7 @@ #include #include #include +#include DEFINE_PER_CPU(struct mmu_gather, mmu_gathers); -- 1.6.0.6