mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: dan.j.williams@intel.com, maciej.sosnowski@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] I/OAT: Convert to PCI_VDEVICE()
Date: Wed, 01 Jul 2009 12:12:16 -0700	[thread overview]
Message-ID: <1246475536.28915.48.camel@Joe-Laptop.home> (raw)
In-Reply-To: <adaprckff1y.fsf@cisco.com>

On Wed, 2009-07-01 at 11:12 -0700, Roland Dreier wrote:
> Trivial cleanup to make the PCI ID table easier to read.

Should this be done tree-wide?

Maybe there should be some new #defines like:

#define PCI_NAMED_DEVICE(vendor, device) \
	PCI_DEVICE(PCI_VENDOR_ID_##vendor, PCI_DEVICE_ID_##vendor##_##device)

#define PCI_UNNAMED_DEVICE(vendor, device) \
	PCI_DEVICE(PCI_VENDOR_ID_##vendor, device)



      reply	other threads:[~2009-07-01 19:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01 18:12 Roland Dreier
2009-07-01 19:12 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246475536.28915.48.camel@Joe-Laptop.home \
    --to=joe@perches.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.sosnowski@intel.com \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®