From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Yinghai Lu <yinghai@kernel.org>, Ingo Molnar <mingo@elte.hu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: printk regression?
Date: Thu, 02 Jul 2009 10:38:40 -0700 [thread overview]
Message-ID: <1246556320.28915.92.camel@Joe-Laptop.home> (raw)
In-Reply-To: <alpine.LFD.2.01.0907021020200.4830@localhost.localdomain>
On Thu, 2009-07-02 at 10:27 -0700, Linus Torvalds wrote:
> Of course, some cases are just crazy. Here's one:
>
> arch/m68knommu/kernel/traps.c: printk(KERN_CONT "\n" KERN_EMERG " [%08lx] ", addr);
>
> and I have no clue about why it would have KERN_CONT there.
Generally, it's because hardware is being scanned in little
bits and pieces with partial line printk's being used to
document things "as it happens".
If something odd happens, the "in-progress" printk's are
terminated and another "whoa nellie" printk is done.
There's a bunch of that in drivers/net.
> That makes
> little sense. Again, with the new printk logic, it really should be just
>
> printk(KERN_EMERG " [%08lx] ", addr);
>
> and nothing odd.
Maybe, but your printk change does require that all of
the kernel sources be updated as necessary.
next prev parent reply other threads:[~2009-07-02 17:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 4:14 Yinghai Lu
2009-07-02 4:23 ` Linus Torvalds
2009-07-02 4:28 ` Linus Torvalds
2009-07-02 5:21 ` [PATCH] x86: fix printk calling in print_local_apic Yinghai Lu
2009-07-02 6:12 ` Ingo Molnar
2009-07-02 6:28 ` [PATCH, v2] x86: Fix printk call in print_local_apic() Ingo Molnar
2009-07-02 6:39 ` Yinghai Lu
2009-07-02 6:50 ` [PATCH, v3] " Ingo Molnar
2009-07-02 6:48 ` [PATCH, v2] " Andrew Morton
2009-07-02 6:59 ` [PATCH, v4] " Ingo Molnar
2009-07-02 7:09 ` Ingo Molnar
2009-07-02 7:07 ` [tip:x86/urgent] " tip-bot for Ingo Molnar
2009-07-02 5:42 ` printk regression? Joe Perches
2009-07-02 12:29 ` Michael S. Zick
2009-07-02 15:29 ` Joe Perches
2009-07-02 17:42 ` Linus Torvalds
2009-07-02 17:27 ` Linus Torvalds
2009-07-02 17:38 ` Joe Perches [this message]
2009-07-02 17:43 ` Linus Torvalds
2009-07-06 20:05 ` [PATCH] Remove multiple KERN_ prefixes from printk formats Joe Perches
2009-07-06 20:23 ` Mike Frysinger
2009-07-06 20:29 ` Joe Perches
2009-07-06 20:33 ` Linus Torvalds
2009-07-06 20:36 ` Mike Frysinger
2009-07-08 21:55 ` [PATCH] arch/blackfin/kernel/traps.c: Add visually separating newlines to printks Joe Perches
2009-07-06 20:38 ` [PATCH] Remove multiple KERN_ prefixes from printk formats Joe Perches
2009-07-08 17:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246556320.28915.92.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®