Re: Possible memory leak via inotify_add_watch

[Eric Paris <eparis@redhat.com>]

On Tue, 2009-07-07 at 14:03 +0100, Catalin Marinas wrote:
> On Mon, 2009-07-06 at 22:09 -0400, Eric Paris wrote:
> > On Mon, 2009-07-06 at 23:03 +0100, Catalin Marinas wrote:
> > > Hi Eric,
> > > 
> > > I'm getting a few kmemleak reports like the one below (it may as well
> > > be just a false positive). All of these allocations happened during
> > > udevd.
> > 
> > Any chance you could give this a shot and see if it fixes it up for you?
> 
> I'll give it a try tonight as it only shows on my home machine. But it
> doesn't apply cleanly on 2.6.31-rc2, there is a big hunk in
> inotify_update_watch() which fails to apply. Are there other additional
> patches needed?

Crap, I didn't think so but yes.  I was building it against a linux-next
tree instead of a Linus tree and there is a patch in linux-next which
conflicts with this one   :(

After I sent it I split the patch into just fixing the leak vs fixing
everything else.  I'll get them both applied cleanly on a linus branch
and let you know what I'd like you to test.

Thanks!

-Eric