From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757293AbZGGQZB (ORCPT ); Tue, 7 Jul 2009 12:25:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753727AbZGGQYy (ORCPT ); Tue, 7 Jul 2009 12:24:54 -0400 Received: from mx2.redhat.com ([66.187.237.31]:55737 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752732AbZGGQYx (ORCPT ); Tue, 7 Jul 2009 12:24:53 -0400 Subject: Re: Possible memory leak via inotify_add_watch From: Eric Paris To: Catalin Marinas Cc: Linux Kernel Mailing List In-Reply-To: <1246971833.9451.39.camel@pc1117.cambridge.arm.com> References: <1246932571.2866.90.camel@dhcp235-23.rdu.redhat.com> <1246971833.9451.39.camel@pc1117.cambridge.arm.com> Content-Type: text/plain Date: Tue, 07 Jul 2009 12:24:07 -0400 Message-Id: <1246983847.2866.118.camel@dhcp235-23.rdu.redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2009-07-07 at 14:03 +0100, Catalin Marinas wrote: > On Mon, 2009-07-06 at 22:09 -0400, Eric Paris wrote: > > On Mon, 2009-07-06 at 23:03 +0100, Catalin Marinas wrote: > > > Hi Eric, > > > > > > I'm getting a few kmemleak reports like the one below (it may as well > > > be just a false positive). All of these allocations happened during > > > udevd. > > > > Any chance you could give this a shot and see if it fixes it up for you? > > I'll give it a try tonight as it only shows on my home machine. But it > doesn't apply cleanly on 2.6.31-rc2, there is a big hunk in > inotify_update_watch() which fails to apply. Are there other additional > patches needed? http://git.infradead.org/users/eparis/notify.git?a=shortlog;h=refs/heads/for-linus Has 3 patches on top. I believe only #2 is needed for the memory leak. -Eric