From: David Woodhouse <dwmw2@infradead.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
Sachin Sant <sachinp@in.ibm.com>
Subject: Re: Possible memory leak in request_firmware()
Date: Wed, 08 Jul 2009 09:56:34 +0100 [thread overview]
Message-ID: <1247043394.25994.0.camel@macbook.infradead.org> (raw)
In-Reply-To: <d82e647a0907080142q65a044aeie50048cba2ac636a@mail.gmail.com>
On Wed, 2009-07-08 at 16:42 +0800, Ming Lei wrote:
>
> IMHO, No.
> If nr_pages is not cleaned, pages pointed by pages[] will be freed
> by fw_dev_release, but they should be freed by vfree()
> in release_firmware. Right?
Yes, sorry -- you're right, and the original patch is fine.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2009-07-08 8:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 15:17 Catalin Marinas
2009-07-07 17:01 ` Cornelia Huck
2009-07-07 21:50 ` Catalin Marinas
2009-07-08 4:38 ` Ming Lei
2009-07-08 6:28 ` David Woodhouse
2009-07-08 8:42 ` Ming Lei
2009-07-08 8:56 ` David Woodhouse [this message]
2009-07-08 0:18 ` Ming Lei
2009-07-10 17:36 ` Greg KH
2009-07-10 22:49 ` Catalin Marinas
2009-07-10 22:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247043394.25994.0.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=catalin.marinas@arm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sachinp@in.ibm.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®