From: Joe Perches <joe@perches.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Vegard Nossum <vegard.nossum@gmail.com>
Subject: Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
Date: Thu, 09 Jul 2009 12:35:39 -0700 [thread overview]
Message-ID: <1247168139.3461.2.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20090709150810.GA25112@rakim.wolfsonmicro.main>
On Thu, 2009-07-09 at 16:08 +0100, Mark Brown wrote:
> That's pretty much what I was thinking of too - tweaking the values for
> the log queries based on the total number of hits so people only turn up
> if they did a certain proportion of the commits. It'd take some
> experimentation to work out what the values to use should be, I guess.
Perhaps something like this:
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 7fc09fc..a97f248 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -27,6 +27,7 @@ my $email_git = 1;
my $email_git_penguin_chiefs = 0;
my $email_git_min_signatures = 1;
my $email_git_max_maintainers = 5;
+my $email_git_min_percent = 0;
my $email_git_since = "1-year-ago";
my $output_multiline = 1;
my $output_separator = ", ";
@@ -65,6 +66,7 @@ if (!GetOptions(
'git-chief-penguins!' => \$email_git_penguin_chiefs,
'git-min-signatures=i' => \$email_git_min_signatures,
'git-max-maintainers=i' => \$email_git_max_maintainers,
+ 'git-min-percent=i' => \$email_git_min_percent,
'git-since=s' => \$email_git_since,
'm!' => \$email_maintainer,
'n!' => \$email_usename,
@@ -307,6 +309,7 @@ MAINTAINER field selection options:
--git-chief-penguins => include ${penguin_chiefs}
--git-min-signatures => number of signatures required (default: 1)
--git-max-maintainers => maximum maintainers to add (default: 5)
+ --git-min-percent => minimum percentage of commits required (default: 0)
--git-since => git history to use (default: 1-year-ago)
--m => include maintainer(s) if any
--n => include name 'Full Name <addr\@domain.tld>'
@@ -497,6 +500,7 @@ sub recent_git_signoffs {
my $output = "";
my $count = 0;
my @lines = ();
+ my $total_sign_offs;
if (which("git") eq "") {
warn("$P: git not found. Add --nogit to options?\n");
@@ -520,6 +524,14 @@ sub recent_git_signoffs {
$output =~ s/^\s*//gm;
@lines = split("\n", $output);
+
+ $total_sign_offs = 0;
+ foreach my $line (@lines) {
+ if ($line =~ m/([0-9]+)\s+(.*)/) {
+ $total_sign_offs += $1;
+ }
+ }
+
foreach my $line (@lines) {
if ($line =~ m/([0-9]+)\s+(.*)/) {
my $sign_offs = $1;
@@ -529,6 +541,11 @@ sub recent_git_signoffs {
$count > $email_git_max_maintainers) {
last;
}
+ if ($email_git_min_percent > 0 &&
+ (($sign_offs * 100 / $total_sign_offs) < $email_git_min_percent)
+ ) {
+ last;
+ }
} else {
die("$P: Unexpected git output: ${line}\n");
}
next prev parent reply other threads:[~2009-07-09 19:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 5:55 [PATCH 0/7] MAINTAINERS: cleanups Joe Perches
2009-07-08 5:55 ` [PATCH 1/7] MAINTAINERS: IA64 - pair P:/M: entries properly Joe Perches
2009-07-08 5:55 ` [PATCH 2/7] MAINTAINERS: Remove ivtv-user lists, add CX18 url Joe Perches
2009-07-08 5:55 ` [PATCH 3/7] MAINTAINERS: QLGE 10Gb ETHERNET - pair P:/M: entries properly Joe Perches
2009-07-08 5:55 ` [PATCH 4/7] MAINTAINERS: Use tabs in ACER ASPIRE ONE Joe Perches
2009-07-08 5:55 ` [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org Joe Perches
2009-07-08 6:32 ` Pekka Enberg
2009-07-08 6:39 ` Joe Perches
2009-07-08 6:44 ` Pekka Enberg
2009-07-08 6:47 ` Joe Perches
2009-07-08 6:55 ` Pekka Enberg
2009-07-08 16:37 ` Maciej W. Rozycki
2009-07-09 9:30 ` Mark Brown
2009-07-09 14:58 ` Joe Perches
2009-07-09 15:08 ` Mark Brown
2009-07-09 19:35 ` Joe Perches [this message]
2009-07-10 13:17 ` Mark Brown
2009-07-10 16:25 ` Joe Perches
2009-07-10 18:44 ` Mark Brown
2009-07-10 19:16 ` Joe Perches
2009-07-08 5:55 ` [PATCH 6/7] MAINTAINERS: Move ARPD to CREDITS Joe Perches
2009-07-08 5:55 ` [PATCH 7/7] MAINTAINERS: Update KERNEL JANITORS Joe Perches
2009-07-09 2:25 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247168139.3461.2.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®