From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Kay Sievers <kay.sievers@vrfy.org>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 3/9] sparc: remove driver-core BUS_ID_SIZE
Date: Sun, 12 Jul 2009 15:46:00 -0700 [thread overview]
Message-ID: <1247438766-17266-3-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20090712223717.GB16600@kroah.com>
From: Kay Sievers <kay.sievers@vrfy.org>
The name size limit is gone from the driver-core, the BUS_ID_SIZE
value will be removed.
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
arch/sparc/kernel/vio.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/arch/sparc/kernel/vio.c b/arch/sparc/kernel/vio.c
index 753d128..c28c714 100644
--- a/arch/sparc/kernel/vio.c
+++ b/arch/sparc/kernel/vio.c
@@ -224,7 +224,12 @@ static struct vio_dev *vio_create_one(struct mdesc_handle *hp, u64 mp,
if (!strcmp(type, "domain-services-port"))
bus_id_name = "ds";
- if (strlen(bus_id_name) >= BUS_ID_SIZE - 4) {
+ /*
+ * 20 char is the old driver-core name size limit, which is no more.
+ * This check can probably be removed after review and possible
+ * adaption of the vio users name length handling.
+ */
+ if (strlen(bus_id_name) >= 20 - 4) {
printk(KERN_ERR "VIO: bus_id_name [%s] is too long.\n",
bus_id_name);
return NULL;
--
1.6.3.2
next prev parent reply other threads:[~2009-07-12 22:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-12 22:37 [GIT PATCH] driver core patches for 2.6.31-rc2-git Greg KH
2009-07-12 22:45 ` [PATCH 1/9] devres: WARN() and return, don't crash on device_del() of uninitialized device Greg Kroah-Hartman
2009-07-15 4:16 ` Tejun Heo
2009-07-12 22:45 ` [PATCH 2/9] partitions: fix broken uevent_suppress conversion Greg Kroah-Hartman
2009-07-12 22:46 ` Greg Kroah-Hartman [this message]
2009-07-13 1:20 ` [PATCH 3/9] sparc: remove driver-core BUS_ID_SIZE David Miller
2009-07-12 22:46 ` [PATCH 4/9] Driver Core: remove BUS_ID_SIZE Greg Kroah-Hartman
2009-07-12 22:46 ` [PATCH 5/9] Firmware: firmware_class, fix lock imbalance Greg Kroah-Hartman
2009-07-12 22:46 ` [PATCH 6/9] driver model: fix show/store prototypes in doc Greg Kroah-Hartman
2009-07-12 22:46 ` [PATCH 7/9] Sound: remove direct access of driver_data Greg Kroah-Hartman
2009-07-13 9:44 ` Mark Brown
2009-07-14 3:59 ` Greg KH
2009-07-12 22:46 ` [PATCH 8/9] omap: video: " Greg Kroah-Hartman
2009-07-12 22:46 ` [PATCH 9/9] wm97xx_batery: replace driver_data with dev_get_drvdata() Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247438766-17266-3-git-send-email-gregkh@suse.de \
--to=gregkh@suse.de \
--cc=davem@davemloft.net \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®