mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Alexey Fisher <bug-track@fisher-privat.net>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	Kernel Testers List <kernel-testers@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sam Ravnborg <sam@ravnborg.org>, Ingo Molnar <mingo@elte.hu>,
	x86@kernel.org
Subject: [PATCH] x86: _edata should include all .data.* sections on X86_64
Date: Tue, 14 Jul 2009 10:52:55 +0100	[thread overview]
Message-ID: <1247565175.28240.37.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <1247564356.28240.30.camel@pc1117.cambridge.arm.com>

The .data.read_mostly and .data.cacheline_aligned sections aren't
covered by the _sdata .. _edata range on X86_64. This affects the
kmemleak reporting leading to possible false positives by not scanning
all the whole data section.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Ingo Molnar <mingo@elte.hu>
---

(I re-posted this patch with comments and cc'ing the relevant people)

 arch/x86/kernel/vmlinux.lds.S |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index 367e878..59f31d2 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -112,11 +112,6 @@ SECTIONS
 		_sdata = .;
 		DATA_DATA
 		CONSTRUCTORS
-
-#ifdef CONFIG_X86_64
-		/* End of data section */
-		_edata = .;
-#endif
 	} :data
 
 #ifdef CONFIG_X86_32
@@ -156,10 +151,8 @@ SECTIONS
 	.data.read_mostly : AT(ADDR(.data.read_mostly) - LOAD_OFFSET) {
 		*(.data.read_mostly)
 
-#ifdef CONFIG_X86_32
 		/* End of data section */
 		_edata = .;
-#endif
 	}
 
 #ifdef CONFIG_X86_64



  reply	other threads:[~2009-07-14 10:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14  6:08 60 memory leaks.. or is it some thing wrong with kmemleak? Alexey Fisher
2009-07-14  7:19 ` Pekka Enberg
2009-07-14  8:28   ` Alexey Fisher
2009-07-14  9:39     ` Catalin Marinas
2009-07-14  9:52       ` Catalin Marinas [this message]
2009-07-14 10:13         ` [PATCH] x86: _edata should include all .data.* sections on X86_64 Alexey Fisher
2009-07-14 10:31           ` Catalin Marinas
2009-07-14 10:37             ` Alexey Fisher
2009-07-14 12:26               ` ext4 memory leak (was Re: [PATCH] x86: _edata should include all .data.* sections on X86_64) Catalin Marinas
2009-07-15  8:03                 ` Aneesh Kumar K.V
2009-07-15  8:54                   ` Alexey Fisher
2009-07-18 11:55                     ` Ingo Molnar
2009-07-18 13:30                       ` Alexey Fisher
2009-07-18 22:44                         ` Catalin Marinas
2009-07-18 22:33                       ` Catalin Marinas
2009-07-15 10:33                   ` Catalin Marinas
2009-07-14 12:42               ` [PATCH] x86: _edata should include all .data.* sections on X86_64 Catalin Marinas
2009-07-16 20:23         ` Sam Ravnborg
2009-07-18 12:06         ` [tip:x86/urgent] x86: Include all of .data.* sections in _edata on 64-bit tip-bot for Catalin Marinas
2009-07-18 20:29       ` [kmemleak] 60 wornings on sysfs_new_dirent+0x10c Alexey Fisher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247565175.28240.37.camel@pc1117.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=bug-track@fisher-privat.net \
    --cc=kernel-testers@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --cc=sam@ravnborg.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome