mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-acpi@vger.kernel.org, rpurdie@rpsys.net, lenb@kernel.org,
	rui.zhang@intel.com, corentincj@iksaif.net,
	Matthew Garrett <mjg@redhat.com>
Subject: [PATCH 1/3] backlight: Allow drivers to update the core, and generate events on changes
Date: Tue, 14 Jul 2009 17:06:02 +0100	[thread overview]
Message-ID: <1247587564-27737-1-git-send-email-mjg@redhat.com> (raw)

Certain hardware will send us events when the backlight brightness
changes. Add a function to update the value in the core, and
additionally send a uevent so that userspace can pop up appropriate
UI. The uevents are flagged depending on whether the update originated
in the kernel or from userspace, making it easier to only display UI
at the appropriate time.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
---

Updated to allow drivers to provide a reason for the change

 drivers/video/backlight/backlight.c |   41 +++++++++++++++++++++++++++++++++++
 include/linux/backlight.h           |    7 ++++++
 2 files changed, 48 insertions(+), 0 deletions(-)

diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
index 157057c..01efb2d 100644
--- a/drivers/video/backlight/backlight.c
+++ b/drivers/video/backlight/backlight.c
@@ -73,6 +73,26 @@ static inline void backlight_unregister_fb(struct backlight_device *bd)
 }
 #endif /* CONFIG_FB */
 
+static void backlight_generate_event(struct backlight_device *bd,
+				     enum backlight_update_reason reason)
+{
+	char *envp[2];
+
+	switch (reason) {
+	case BACKLIGHT_UPDATE_SYSFS:
+		envp[0] = "SOURCE=sysfs";
+		break;
+	case BACKLIGHT_UPDATE_HOTKEY:
+		envp[0] = "SOURCE=hotkey";
+		break;
+	default:
+		envp[0] = "SORUCE=unknown";
+		break;
+	}
+	envp[1] = NULL;
+	kobject_uevent_env(&bd->dev.kobj, KOBJ_CHANGE, envp);
+}
+
 static ssize_t backlight_show_power(struct device *dev,
 		struct device_attribute *attr,char *buf)
 {
@@ -142,6 +162,8 @@ static ssize_t backlight_store_brightness(struct device *dev,
 	}
 	mutex_unlock(&bd->ops_lock);
 
+	backlight_generate_event(bd, BACKLIGHT_UPDATE_SYSFS);
+
 	return rc;
 }
 
@@ -214,6 +236,25 @@ static struct device_attribute bl_device_attributes[] = {
 };
 
 /**
+ * backlight_force_update - tell the backlight subsystem that hardware state
+ *   has changed
+ * @bd: the backlight device to update
+ *
+ * Updates the internal state of the backlight in response to a hardware event,
+ * and generate a uevent to notify userspace
+ */
+void backlight_force_update(struct backlight_device *bd,
+			    enum backlight_update_reason reason)
+{
+	mutex_lock(&bd->ops_lock);
+	if (bd->ops && bd->ops->get_brightness)
+		bd->props.brightness = bd->ops->get_brightness(bd);
+	mutex_unlock(&bd->ops_lock);
+	backlight_generate_event(bd, reason);
+}
+EXPORT_SYMBOL(backlight_force_update);
+
+/**
  * backlight_device_register - create and register a new object of
  *   backlight_device class.
  * @name: the name of the new object(must be the same as the name of the
diff --git a/include/linux/backlight.h b/include/linux/backlight.h
index 79ca2da..0f5f578 100644
--- a/include/linux/backlight.h
+++ b/include/linux/backlight.h
@@ -27,6 +27,11 @@
  * Any other use of the locks below is probably wrong.
  */
 
+enum backlight_update_reason {
+	BACKLIGHT_UPDATE_HOTKEY,
+	BACKLIGHT_UPDATE_SYSFS,
+};
+
 struct backlight_device;
 struct fb_info;
 
@@ -100,6 +105,8 @@ static inline void backlight_update_status(struct backlight_device *bd)
 extern struct backlight_device *backlight_device_register(const char *name,
 	struct device *dev, void *devdata, struct backlight_ops *ops);
 extern void backlight_device_unregister(struct backlight_device *bd);
+extern void backlight_force_update(struct backlight_device *bd,
+				   enum backlight_update_reason reason);
 
 #define to_backlight_device(obj) container_of(obj, struct backlight_device, dev)
 
-- 
1.6.2.5


             reply	other threads:[~2009-07-14 16:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14 16:06 Matthew Garrett [this message]
2009-07-14 16:06 ` [PATCH 2/3] ACPI: Update the backlight state when we change brightness Matthew Garrett
2009-07-14 16:06   ` [PATCH 3/3] eeepc-laptop: " Matthew Garrett
2009-07-15  9:40     ` Corentin Chary
2009-07-16 21:33 ` [PATCH 1/3] backlight: Allow drivers to update the core, and generate events on changes Michal Schmidt
2009-07-18 11:48 ` Pavel Machek
2009-09-19 23:24 ` Henrique de Moraes Holschuh
2009-09-20  4:15   ` Matthew Garrett
2009-09-20 11:16     ` Henrique de Moraes Holschuh
  -- strict thread matches above, loose matches on Subject: below --
2009-07-13 20:41 Matthew Garrett
2009-07-14  0:58 ` ykzhao
2009-07-14  1:53   ` Matthew Garrett
2009-07-14 15:48     ` Matthew Garrett
2009-07-14 10:30 ` Henrique de Moraes Holschuh
2009-07-14 13:21   ` Matthew Garrett
2009-07-14 15:54     ` Henrique de Moraes Holschuh
2009-07-14 12:29 ` Richard Purdie
2009-07-14 12:55   ` Matthew Garrett
2009-07-15  7:55   ` Zhang Rui
2009-07-15  8:22     ` Richard Purdie
2009-07-15  8:38       ` Zhang Rui
2009-07-15  9:11         ` Richard Purdie
2009-07-15 13:58           ` Matthew Garrett
2009-07-16  2:39             ` Zhang Rui
2009-07-16  2:40               ` Matthew Garrett
2009-07-29 15:05                 ` Pavel Machek
2009-07-29 15:20                   ` Matthew Garrett
2009-07-29 15:31                     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247587564-27737-1-git-send-email-mjg@redhat.com \
    --to=mjg@redhat.com \
    --cc=corentincj@iksaif.net \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®