From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: me@felipe.balbi.com
Cc: linux-kernel@vger.kernel.org, rpurdie@linux.intel.com,
rpurdie@rpsys.net, srcvale@holoscopio.com,
Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Subject: [PATCH 3/3] After setting inverted attribute, we must update the LED.
Date: Tue, 14 Jul 2009 14:03:35 -0300 [thread overview]
Message-ID: <1247591015-2428-3-git-send-email-cascardo@holoscopio.com> (raw)
In-Reply-To: <1247591015-2428-2-git-send-email-cascardo@holoscopio.com>
If we change the inverted attribute to another value, the LED will not
be inverted until we change the GPIO state.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
---
drivers/leds/ledtrig-gpio.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/leds/ledtrig-gpio.c b/drivers/leds/ledtrig-gpio.c
index 7c9aff9..1136f50 100644
--- a/drivers/leds/ledtrig-gpio.c
+++ b/drivers/leds/ledtrig-gpio.c
@@ -117,6 +117,9 @@ static ssize_t gpio_trig_inverted_store(struct device *dev,
gpio_data->inverted = !!inverted;
+ /* After inverting, we need to update the LED. */
+ schedule_work(&gpio_data->work);
+
return n;
}
static DEVICE_ATTR(inverted, 0644, gpio_trig_inverted_show,
--
1.6.3.3
next prev parent reply other threads:[~2009-07-14 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 17:03 [PATCH 1/3] Trivial: Fix coding style in worker thread code for ledtrig-gpio Thadeu Lima de Souza Cascardo
2009-07-14 17:03 ` [PATCH 2/3] Fix multiple requests and releases of IRQ for GPIO LED Trigger Thadeu Lima de Souza Cascardo
2009-07-14 17:03 ` Thadeu Lima de Souza Cascardo [this message]
2009-07-14 17:58 ` [PATCH] Trivial: Fix coding style in worker thread code for ledtrig-gpio Thadeu Lima de Souza Cascardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247591015-2428-3-git-send-email-cascardo@holoscopio.com \
--to=cascardo@holoscopio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@felipe.balbi.com \
--cc=rpurdie@linux.intel.com \
--cc=rpurdie@rpsys.net \
--cc=srcvale@holoscopio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®