From: Xiaotian Feng <dfeng@redhat.com>
To: menage@google.com, lizf@cn.fujitsu.com,
containers@lists.linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Xiaotian Feng <dfeng@redhat.com>
Subject: [PATCH] cgroup: fix reverse unlock sequence in cgroup_get_sb
Date: Tue, 21 Jul 2009 18:25:26 +0800 [thread overview]
Message-ID: <1248171926-20232-1-git-send-email-dfeng@redhat.com> (raw)
In cgroup_get_sb, the lock sequence is:
mutex_lock(&inode->i_mutex);
mutex_lock(&cgroup->mutex);
so the last unlock sequence should be:
mutex_unlock(&cgroup->mutex);
mutex_unlock(&inode->i_mutex);
Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
---
kernel/cgroup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 3737a68..11ef162 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1140,8 +1140,8 @@ static int cgroup_get_sb(struct file_system_type *fs_type,
BUG_ON(root->number_of_cgroups != 1);
cgroup_populate_dir(root_cgrp);
- mutex_unlock(&inode->i_mutex);
mutex_unlock(&cgroup_mutex);
+ mutex_unlock(&inode->i_mutex);
}
simple_set_mnt(mnt, sb);
--
1.6.2.5
next reply other threads:[~2009-07-21 10:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 10:25 Xiaotian Feng [this message]
2009-07-21 11:10 ` Balbir Singh
2009-07-21 11:12 ` Danny Feng
[not found] ` <8522a3d30907210438u6fce081fi835bf964d0c01e8a@mail.gmail.com>
2009-07-21 12:01 ` Balbir Singh
2009-07-21 15:34 ` Paul Menage
2009-07-21 15:47 ` Balbir Singh
2009-07-22 0:53 ` Li Zefan
2009-07-22 1:42 ` Danny Feng
2009-07-21 16:03 ` Paul Menage
2009-07-22 1:57 ` Danny Feng
2009-07-22 2:18 ` Li Zefan
2009-07-22 2:32 ` Danny Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248171926-20232-1-git-send-email-dfeng@redhat.com \
--to=dfeng@redhat.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®