mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tom.leiming@gmail.com
To: a.p.zijlstra@chello.nl
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	mingo@elte.hu, torvalds@linux-foundation.org,
	Ming Lei <tom.leiming@gmail.com>
Subject: [tip:core/locking 3/3] lockdep:add likely/unlikely annotations to BFS core routine
Date: Wed, 22 Jul 2009 20:58:33 +0800	[thread overview]
Message-ID: <1248267513-4934-4-git-send-email-tom.leiming@gmail.com> (raw)
In-Reply-To: <1248267513-4934-3-git-send-email-tom.leiming@gmail.com>

From: Ming Lei <tom.leiming@gmail.com>

Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
 kernel/lockdep.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 1583439..2bf49ae 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -951,18 +951,18 @@ static int __bfs(struct lock_list *source_entry,
 	else
 		head = &source_entry->class->locks_before;
 
-	if (list_empty(head))
+	if (unlikely(list_empty(head)))
 		goto exit;
 
 	__cq_init(cq);
 	__cq_enqueue(cq, (unsigned long)source_entry);
 
-	while (!__cq_empty(cq)) {
+	while (likely(!__cq_empty(cq))) {
 		struct lock_list *lock;
 
 		__cq_dequeue(cq, (unsigned long *)&lock);
 
-		if (!lock->class) {
+		if (unlikely(!lock->class)) {
 			ret = -2;
 			goto exit;
 		}
@@ -982,12 +982,12 @@ static int __bfs(struct lock_list *source_entry,
 					goto exit;
 				}
 
-				if (__cq_enqueue(cq, (unsigned long)entry)) {
+				if (unlikely(__cq_enqueue(cq, (unsigned long)entry))) {
 					ret = -1;
 					goto exit;
 				}
 				cq_depth = __cq_get_elem_count(cq);
-				if (max_bfs_queue_depth < cq_depth)
+				if (unlikely(max_bfs_queue_depth < cq_depth))
 					max_bfs_queue_depth = cq_depth;
 			}
 		}
-- 
1.6.0.GIT


  reply	other threads:[~2009-07-22 12:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-22 12:58 [tip:core/locking 0/3] lockdep:bfs optimization tom.leiming
2009-07-22 12:58 ` [tip:core/locking 1/3] lockdep:reintroduce generation count to make BFS faster tom.leiming
2009-07-22 12:58   ` [tip:core/locking 2/3] lockdep:define preallocated "stack" for BFS as per cpu variable tom.leiming
2009-07-22 12:58     ` tom.leiming [this message]
2009-07-22 13:06       ` [tip:core/locking 3/3] lockdep:add likely/unlikely annotations to BFS core routine Peter Zijlstra
2009-07-22 13:03     ` [tip:core/locking 2/3] lockdep:define preallocated "stack" for BFS as per cpu variable Peter Zijlstra
2009-07-22 13:10       ` Ming Lei
2009-07-22 13:19         ` Peter Zijlstra
2009-07-22 13:45           ` Ming Lei
2009-07-22 13:04   ` [tip:core/locking 1/3] lockdep:reintroduce generation count to make BFS faster Peter Zijlstra
2009-07-22 13:17     ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248267513-4934-4-git-send-email-tom.leiming@gmail.com \
    --to=tom.leiming@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®