From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: don't use current_cpu_data in x2apic phys_pkg_id
Date: Mon, 27 Jul 2009 11:44:06 -0700 [thread overview]
Message-ID: <1248720246.27006.10764.camel@localhost.localdomain> (raw)
In-Reply-To: <4A6ADD0D.10002@kernel.org>
On Sat, 2009-07-25 at 03:23 -0700, Yinghai Lu wrote:
> one system that socket 1 come up as BSP. kexeced kernel report BSP as:
> [ 1.524550] Initializing cgroup subsys cpuacct
> [ 1.536064] initial_apicid:20
> [ 1.537135] ht_mask_width:1
> [ 1.538128] core_select_mask:f
> [ 1.539126] core_plus_mask_width:5
> [ 1.558479] CPU: Physical Processor ID: 0
> [ 1.559501] CPU: Processor Core ID: 0
> [ 1.560539] CPU: L1 I cache: 32K, L1 D cache: 32K
> [ 1.579098] CPU: L2 cache: 256K
> [ 1.580085] CPU: L3 cache: 24576K
> [ 1.581108] CPU 0/0x20 -> Node 0
> [ 1.596193] CPU 0 microcode level: 0xffff0008
>
> it doesn't have correct physical processor id. and will get error
> [ 38.840859] CPU0 attaching sched-domain:
> [ 38.848287] domain 0: span 0,8,72 level SIBLING
> [ 38.851151] groups: 0 8 72
> [ 38.858137] domain 1: span 0,8-15,72-79 level MC
> [ 38.868944] groups: 0,8,72 9,73 10,74 11,75 12,76 13,77 14,78 15,79
> [ 38.881383] ERROR: parent span is not a superset of domain->span
> [ 38.890724] domain 2: span 0-7,64-71 level CPU
> [ 38.899237] ERROR: domain->groups does not contain CPU0
> [ 38.909229] groups: 8-15,72-79
> [ 38.912547] ERROR: groups don't span domain->span
> [ 38.919665] domain 3: span 0-127 level NODE
> [ 38.930739] groups: 0-7,64-71 8-15,72-79 16-23,80-87 24-31,88-95 32-39,96-103 40-47,104-111 48-55,112-119 56-63,120-127
>
> it turns out:
> we can not use current_cpu_data in phys_pgd_id for x2apic.
>
> identify_boot_cpu is called by check_bugs before smp_prepare_cpus.
> and till smp_prepare_cpus current_cpu_data for bsp is assigned with
> boot_cpu_data
>
> just make phys_pkg_id for x2apic is aligned to xapic
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
next prev parent reply other threads:[~2009-07-27 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-25 10:23 Yinghai Lu
2009-07-27 18:44 ` Suresh Siddha [this message]
2009-08-04 15:32 ` [tip:x86/urgent] x86: Don't " tip-bot for Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248720246.27006.10764.camel@localhost.localdomain \
--to=suresh.b.siddha@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome