From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1752833AbZG1RAu@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752833AbZG1RAu (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jul 2009 13:00:50 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751669AbZG1RAu
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 28 Jul 2009 13:00:50 -0400
Received: from mx2.netapp.com ([216.240.18.37]:47085 "EHLO mx2.netapp.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751376AbZG1RAt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jul 2009 13:00:49 -0400
X-IronPort-AV: E=Sophos;i="4.43,284,1246863600"; 
   d="scan'208";a="214056246"
Subject: Re: [PATCH] nfs: remove superfluous BUG_ON()s
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
       Dan Carpenter <error27@gmail.com>, corbet@lwn.net, eteo@redhat.com,
       Julia Lawall <julia@diku.dk>
In-Reply-To: <200907281704.56870.bzolnier@gmail.com>
References: <200907281704.56870.bzolnier@gmail.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Organization: NetApp
Date: Tue, 28 Jul 2009 12:59:10 -0400
Message-Id: <1248800350.6205.7.camel@heimdal.trondhjem.org>
Mime-Version: 1.0
X-Mailer: Evolution 2.26.1 
X-OriginalArrivalTime: 28 Jul 2009 17:00:02.0001 (UTC) FILETIME=[D8CF7C10:01CA0FA4]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2009-07-28 at 17:04 +0200, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] nfs: remove superfluous BUG_ON()s
> 
> Remove duplicated BUG_ON()s from nfs[4]_create_server()
> (we make the same checks earlier in both functions).
> 
> This takes care of the following entries from Dan's list:
> 
> fs/nfs/client.c +1078 nfs_create_server(47) warning: variable derefenced before check 'server->nfs_client'
> fs/nfs/client.c +1079 nfs_create_server(48) warning: variable derefenced before check 'server->nfs_client->rpc_ops'
> fs/nfs/client.c +1363 nfs4_create_server(43) warning: variable derefenced before check 'server->nfs_client'
> fs/nfs/client.c +1364 nfs4_create_server(44) warning: variable derefenced before check 'server->nfs_
> 
> Reported-by: Dan Carpenter <error27@gmail.com>
> Cc: corbet@lwn.net
> Cc: eteo@redhat.com
> Cc: Julia Lawall <julia@diku.dk>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Thanks! I will apply...

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com