mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Stoyan Gaydarov <sgayda2@uiuc.edu>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, acme@redhat.com,
	efault@gmx.de
Subject: Re: [PATCH 4/4] [perf] fixed faulty check
Date: Thu, 30 Jul 2009 12:51:26 +0200	[thread overview]
Message-ID: <1248951086.6391.11.camel@twins> (raw)
In-Reply-To: <1248949529-20891-1-git-send-email-sgayda2@uiuc.edu>

On Thu, 2009-07-30 at 05:25 -0500, Stoyan Gaydarov wrote:
> This patche fixes a spelling error that has resulted from copy and
> pasting. The location of the error was found using a semantic patch
> but the semantic patch was not trying to find these errors. After
> looking things over it seemed logical that this change was needed.
> Please review it and then include the patch if it is in fact the
> correct change.

Looks sane to me. I'll pick it up. Thanks!

> Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
> ---
>  tools/perf/util/symbol.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index 2810605..b4fe057 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -565,7 +565,7 @@ static int dso__load_sym(struct dso *self, int fd, const char *name,
>  		goto out_elf_end;
>  
>  	secstrs = elf_getdata(sec_strndx, NULL);
> -	if (symstrs == NULL)
> +	if (secstrs == NULL)
>  		goto out_elf_end;
>  
>  	nr_syms = shdr.sh_size / shdr.sh_entsize;


  reply	other threads:[~2009-07-30 10:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-30 10:25 Stoyan Gaydarov
2009-07-30 10:51 ` Peter Zijlstra [this message]
2009-08-02 13:10 ` [tip:perfcounters/core] perf tools: Fix " tip-bot for Stoyan Gaydarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248951086.6391.11.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sgayda2@uiuc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome