From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754400AbcKUMdV (ORCPT ); Mon, 21 Nov 2016 07:33:21 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:58146 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754274AbcKUMdT (ORCPT ); Mon, 21 Nov 2016 07:33:19 -0500 Subject: Re: Synopsys Ethernet QoS Driver To: Rayagond Kokatanur , Rabin Vincent , Giuseppe Cavallaro References: <1dbb6047-2bbb-4d56-2a62-ab65a0254844@synopsys.com> <20161119135654.GA14079@lnxartpec.se.axis.com> CC: Joao Pinto , mued dib , David Miller , Jeff Kirsher , , , , netdev , , , , , From: Joao Pinto Message-ID: <1248f4ce-4859-10e6-fef9-342ea543f8d4@synopsys.com> Date: Mon, 21 Nov 2016 12:32:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.25.130] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 21-11-2016 05:29, Rayagond Kokatanur wrote: > On Sat, Nov 19, 2016 at 7:26 PM, Rabin Vincent wrote: >> On Fri, Nov 18, 2016 at 02:20:27PM +0000, Joao Pinto wrote: >>> For now we are interesting in improving the synopsys QoS driver under >>> /nect/ethernet/synopsys. For now the driver structure consists of a single file >>> called dwc_eth_qos.c, containing synopsys ethernet qos common ops and platform >>> related stuff. >>> >>> Our strategy would be: >>> >>> a) Implement a platform glue driver (dwc_eth_qos_pltfm.c) >>> b) Implement a pci glue driver (dwc_eth_qos_pci.c) >>> c) Implement a "core driver" (dwc_eth_qos.c) that would only have Ethernet QoS >>> related stuff to be reused by the platform / pci drivers >>> d) Add a set of features to the "core driver" that we have available internally >> >> Note that there are actually two drivers in mainline for this hardware: >> >> drivers/net/ethernet/synopsis/ >> drivers/net/ethernet/stmicro/stmmac/ > > Yes the later driver (drivers/net/ethernet/stmicro/stmmac/) supports > both 3.x and 4.x. It has glue layer for pci, platform, core etc, > please refer this driver once before you start. > > You can start adding missing feature of 4.x in stmmac driver. Thanks you all for all the info. Well, I think we are in a good position to organize the ethernet drivers concerning Synopsys IPs. First of all, in my opinion, it does not make sense to have a ethernet/synopsis (typo :)) when ethernet/stmicro is also for a synopsys IP. If we have another vendor using the same IP it should be able to reuse the commonn operations. But I would put that discussion for later :) For now I suggest that for we create ethernet/qos and create there a folder called dwc (designware controller) where all the synopsys qos IP specific code in order to be reused for example by ethernet/stmicro/stmmac/. We just have to figure out a clean interface for "client drivers" like stmmac to interact with the new qos driver. What do you think about this approach? > >> >> (See http://lists.openwall.net/netdev/2016/02/29/127) >> >> The former only supports 4.x of the hardware. >> >> The later supports 4.x and 3.x and already has a platform glue driver >> with support for several platforms, a PCI glue driver, and a core driver >> with several features not present in the former (for example: TX/RX >> interrupt coalescing, EEE, PTP). >> >> Have you evaluated both drivers? Why have you decided to work on the >> former rather than the latter? > > Thanks.