From: Joe Perches <joe@perches.com>
To: "Othman, Ossama" <ossama.othman@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] Moorestown RAR Handler driver, MRST 2.6.31-rc3
Date: Mon, 03 Aug 2009 10:45:33 -0700 [thread overview]
Message-ID: <1249321533.5149.21.camel@Joe-Laptop.home> (raw)
In-Reply-To: <A5FE05C4C76E4C4CAB15D9962B96FC950C7957A872@orsmsx510.amr.corp.intel.com>
On Mon, 2009-08-03 at 10:32 -0700, Othman, Ossama wrote:
> >It is recommended to separate definition,
> >and assignment.
> >So this should look like this:
> > struct memrar_allocator *allocator;
> > allocator = 0;
> Okay, I'll fix that, too. Should this go into Documentation/CodingStyle, too?
I don't agree with that at all, neither does a lot of the kernel source.
Automatic structs with initializers:
$ grep -rP --include=*.c "^\s+struct\s+\w+\s*\*\s*\w+\s*=\s*\w+\s*;" * | wc -l
9498
I think it should be struct memrar_allocator *allocator = NULL;
next prev parent reply other threads:[~2009-08-03 17:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 23:20 Ossama Othman
2009-08-01 7:30 ` Sam Ravnborg
2009-08-01 8:03 ` Joe Perches
2009-08-03 17:35 ` Othman, Ossama
2009-08-03 17:32 ` Othman, Ossama
2009-08-03 17:45 ` Joe Perches [this message]
2009-08-03 17:53 ` Othman, Ossama
2009-08-03 18:31 ` Alan Cox
2009-08-07 18:07 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249321533.5149.21.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ossama.othman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®