From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753365AbZHCSPt (ORCPT ); Mon, 3 Aug 2009 14:15:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753174AbZHCSPt (ORCPT ); Mon, 3 Aug 2009 14:15:49 -0400 Received: from mx2.redhat.com ([66.187.237.31]:39452 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035AbZHCSO4 (ORCPT ); Mon, 3 Aug 2009 14:14:56 -0400 Subject: Re: fanotify - overall design before I start sending patches From: Eric Paris To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, malware-list@dmesg.printk.net, Valdis.Kletnieks@vt.edu, greg@kroah.com, jcm@redhat.com, douglas.leeder@sophos.com, tytso@mit.edu, arjan@infradead.org, david@lang.hm, jengelh@medozas.de, aviro@redhat.com, mrkafk@gmail.com, alexl@redhat.com, jack@suse.cz, tvrtko.ursulin@sophos.com, a.p.zijlstra@chello.nl, alan@lxorguk.ukuu.org.uk, mmorley@hcl.in In-Reply-To: <20090803180437.GA9798@infradead.org> References: <1248466429.3567.82.camel@localhost> <20090803162303.GA31058@infradead.org> <1249318535.2447.26.camel@dhcp231-106.rdu.redhat.com> <20090803180437.GA9798@infradead.org> Content-Type: text/plain Date: Mon, 03 Aug 2009 14:13:24 -0400 Message-Id: <1249323204.2447.38.camel@dhcp231-106.rdu.redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2009-08-03 at 14:04 -0400, Christoph Hellwig wrote: > On Mon, Aug 03, 2009 at 12:55:35PM -0400, Eric Paris wrote: > > In linux-next you will find that those fields are completely unused and > > the kernel can be compiled without them with 0 lose of functionality > > (they are still used in linus's kernel by the audit system) > > > > The only reason I didn't remove them entirely is because the inotify > > kernel interface is EXPORT_SYMBOL. I plan to leave it around for a > > little bit until I'm sure out of tree users don't exist or at least had > > enough time to realize they need to use fsnotify. > > There's absolutely no reason to keep them around, we never guaranteed > API stability and never cared about out of tree modules. And if any > out of tree modules are out there using it they won't notice they need > to stop using it before you removed it. So just nuke them entirely > in the for-2.6.32 queue. Will nuke entirely in .32