mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: use online_mask for x2apic target_cpus
Date: Tue, 04 Aug 2009 10:13:56 -0700	[thread overview]
Message-ID: <1249406036.27006.10785.camel@localhost.localdomain> (raw)
In-Reply-To: <4A785AFF.3050902@kernel.org>

On Tue, 2009-08-04 at 08:59 -0700, Yinghai Lu wrote:
> found one system with x2apic report:
> [  302.859446] igbvf 0000:81:10.4: enabling device (0000 -> 0002)
> [  302.874369] igbvf 0000:81:10.4: using 64bit DMA mask
> [  302.879023] igbvf 0000:81:10.4: using 64bit consistent DMA mask
> [  302.894386] igbvf 0000:81:10.4: enabling bus mastering
> [  302.898171] igbvf 0000:81:10.4: setting latency timer to 64
> [  302.914050] reserve_memtype added 0xefb08000-0xefb0c000, track uncached-minus, req uncached-minus, ret uncached-minus
> [  302.933839] reserve_memtype added 0xefb28000-0xefb29000, track uncached-minus, req uncached-minus, ret uncached-minus
> [  302.940367]   alloc irq_desc for 265 on node 4
> [  302.956874]   alloc kstat_irqs on node 4
> [  302.959452] alloc irq_2_iommu on node 0
> [  302.974328] igbvf 0000:81:10.4: irq 265 for MSI/MSI-X
> [  302.977778]   alloc irq_desc for 266 on node 4
> [  302.980347]   alloc kstat_irqs on node 4
> [  302.995312] free_memtype request 0xefb28000-0xefb29000
> [  302.998816] igbvf 0000:81:10.4: Failed to initialize MSI-X interrupts.
> 
> it turns out that when trying to enable msi-x.
> __assign_irq_vector(new, cfg_new, apic->target_cpus()) can not get vector
> because for x2apic target-cpus return cpumask_of(0)
> 
> update that to online_mask like xapic.
> 
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>

Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>


  reply	other threads:[~2009-08-04 17:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-04 15:59 Yinghai Lu
2009-08-04 17:13 ` Suresh Siddha [this message]
2009-08-08 15:21 ` [tip:x86/urgent] x86: Fix MSI-X initialization by using " tip-bot for Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249406036.27006.10785.camel@localhost.localdomain \
    --to=suresh.b.siddha@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®