mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: <akpm@linux-foundation.org>, <joe@perches.com>,
	<torvalds@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>, <mcgrof@gmail.com>,
	"Luis R. Rodriguez" <lrodriguez@atheros.com>
Subject: [PATCH 1/3] checkincludes.pl: close file as soon as we're done with it
Date: Wed, 5 Aug 2009 17:51:10 -0700	[thread overview]
Message-ID: <1249519872-23958-2-git-send-email-lrodriguez@atheros.com> (raw)
In-Reply-To: <1249519872-23958-1-git-send-email-lrodriguez@atheros.com>

Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
 scripts/checkincludes.pl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/checkincludes.pl b/scripts/checkincludes.pl
index 8e6b716..32ebff6 100755
--- a/scripts/checkincludes.pl
+++ b/scripts/checkincludes.pl
@@ -13,12 +13,12 @@ foreach $file (@ARGV) {
 			++$includedfiles{$1};
 		}
 	}
+
+	close(FILE);
 	
 	foreach $filename (keys %includedfiles) {
 		if ($includedfiles{$filename} > 1) {
 			print "$file: $filename is included more than once.\n";
 		}
 	}
-
-	close(FILE);
 }
-- 
1.6.3.3


  reply	other threads:[~2009-08-06  0:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06  0:51 [PATCH 0/3] checkincludes.pl: add removal option Luis R. Rodriguez
2009-08-06  0:51 ` Luis R. Rodriguez [this message]
2009-08-06  0:51 ` [PATCH 2/3] checkincludes.pl: provide usage helper Luis R. Rodriguez
2009-08-06  0:51 ` [PATCH 3/3] checkincludes.pl: add option to remove duplicates in place Luis R. Rodriguez
2009-08-06  1:59   ` Andrew Morton
2009-08-06  2:10     ` Luis R. Rodriguez
2009-08-06 19:17     ` Daniel K.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249519872-23958-2-git-send-email-lrodriguez@atheros.com \
    --to=lrodriguez@atheros.com \
    --cc=akpm@linux-foundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®