From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Li Zefan <lizf@cn.fujitsu.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH 2/7] tracing/function-graph-tracer: Drop the useless nmi protection
Date: Thu, 6 Aug 2009 08:27:33 +0200 [thread overview]
Message-ID: <1249540058-5528-3-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <20090802195312.GA18598@elte.hu>
The function graph tracer used to have a protection against NMI
while entering a function entry tracing. But this is useless now,
this tracer is reentrant and the ring buffer supports the NMI tracing.
We can then drop this protection.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
---
arch/x86/kernel/ftrace.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
index d94e1ea..8e96634 100644
--- a/arch/x86/kernel/ftrace.c
+++ b/arch/x86/kernel/ftrace.c
@@ -417,10 +417,6 @@ void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr,
unsigned long return_hooker = (unsigned long)
&return_to_handler;
- /* Nmi's are currently unsupported */
- if (unlikely(in_nmi()))
- return;
-
if (unlikely(atomic_read(¤t->tracing_graph_pause)))
return;
--
1.6.2.3
next prev parent reply other threads:[~2009-08-06 6:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 17:13 [GIT PULL] tracing: Various cleanups for 2.6.32 Frederic Weisbecker
2009-07-29 17:13 ` [PATCH 1/6] tracing: Simplify print_graph_cpu() Frederic Weisbecker
2009-07-29 17:13 ` [PATCH 2/6] tracing/function-graph-tracer: Drop the useless nmi protection Frederic Weisbecker
2009-07-29 17:13 ` [PATCH 3/6] tracing/function-tracer: Move trace_function() in the function tracer file Frederic Weisbecker
2009-07-29 17:13 ` [PATCH 4/6] tracing/core: Make the stack entry helpers global Frederic Weisbecker
2009-07-29 17:13 ` [PATCH 5/6] tracing: Move sched event insertion helpers in the sched switch tracer file Frederic Weisbecker
2009-07-29 17:13 ` [PATCH 6/6] tracing/function-graph-tracer: Move graph event insertion helpers in the graph " Frederic Weisbecker
2009-07-30 1:48 ` [GIT PULL] tracing: Various cleanups for 2.6.32 Li Zefan
2009-07-30 13:00 ` Steven Rostedt
2009-08-02 19:34 ` Ingo Molnar
2009-08-02 19:53 ` Ingo Molnar
2009-08-03 1:18 ` Frédéric Weisbecker
2009-08-06 6:27 ` [GIT PULL] tracing: Various cleanups for 2.6.32, v2 Frederic Weisbecker
2009-08-06 12:24 ` Ingo Molnar
2009-08-06 6:27 ` [PATCH 1/7] tracing: Simplify print_graph_cpu() Frederic Weisbecker
2009-08-06 6:27 ` Frederic Weisbecker [this message]
2009-08-06 6:27 ` [PATCH 3/7] tracing/core: Turn ftrace_cpu_disabled into a global var Frederic Weisbecker
2009-08-06 6:27 ` [PATCH 4/7] tracing/core: Make the stack entry helpers global Frederic Weisbecker
2009-08-06 6:27 ` [PATCH 5/7] tracing: Move sched event insertion helpers in the sched switch tracer file Frederic Weisbecker
2009-08-06 6:27 ` [PATCH 6/7] tracing/function-graph-tracer: Move graph event insertion helpers in the graph " Frederic Weisbecker
2009-08-06 6:27 ` [PATCH 7/7] tracing/events: Only define remove_subsystem_dir() if CONFIG_MODULES Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249540058-5528-3-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®