From: "Ozan Çağlayan" <ozan@pardus.org.tr>
To: linux-kernel@vger.kernel.org
Cc: arjan@infradead.org
Subject: [PATCH] markup_oops: Use modinfo to avoid confusion with underscored module names
Date: Thu, 6 Aug 2009 15:21:55 +0300 [thread overview]
Message-ID: <1249561315-2227-1-git-send-email-ozan@pardus.org.tr> (raw)
When EIP is at a module having an underscore in its name, the current
code fails to find it because the module filenames has '-' instead of
'_'.
Use modinfo to correctly get the full path to the module.
Signed-off-by: Ozan Çağlayan <ozan@pardus.org.tr>
---
This is just a trivial patch to pinpoint the problem. Usage of modinfo is faster than
searching through the filesystem but may not be desirable as it brings a dependency
to module-init-tools. Replacing underscore occurences by '-' can be another solution.
scripts/markup_oops.pl | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/scripts/markup_oops.pl b/scripts/markup_oops.pl
index 8977401..bc14f4c 100644
--- a/scripts/markup_oops.pl
+++ b/scripts/markup_oops.pl
@@ -184,10 +184,7 @@ if ($target eq "0") {
# if it's a module, we need to find the .ko file and calculate a load offset
if ($module ne "") {
- my $dir = dirname($filename);
- $dir = $dir . "/";
- my $mod = $module . ".ko";
- my $modulefile = `find $dir -name $mod | head -1`;
+ my $modulefile = `modinfo $module | grep 'filename' | gawk '{ print \$2 }'`;
chomp($modulefile);
$filename = $modulefile;
if ($filename eq "") {
--
1.6.3.4
next reply other threads:[~2009-08-06 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 12:21 Ozan Çağlayan [this message]
2009-08-06 14:11 ` Arjan van de Ven
2009-08-06 15:32 ` Ozan Çağlayan
2009-08-07 1:42 ` Amerigo Wang
2009-08-10 9:13 ` [PATCH v2] " Ozan Çağlayan
2009-08-10 14:37 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249561315-2227-1-git-send-email-ozan@pardus.org.tr \
--to=ozan@pardus.org.tr \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®