From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757220AbZHGINZ (ORCPT ); Fri, 7 Aug 2009 04:13:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757200AbZHGINY (ORCPT ); Fri, 7 Aug 2009 04:13:24 -0400 Received: from casper.infradead.org ([85.118.1.10]:46714 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757192AbZHGINX (ORCPT ); Fri, 7 Aug 2009 04:13:23 -0400 Subject: Re: [PATCH] perf tools: Fix cumul hit based sub-total From: Peter Zijlstra To: Frederic Weisbecker Cc: Ingo Molnar , LKML , Arnaldo Carvalho de Melo , Mike Galbraith , Pekka Enberg In-Reply-To: <1249621865-9325-1-git-send-email-fweisbec@gmail.com> References: <1249621865-9325-1-git-send-email-fweisbec@gmail.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Fri, 07 Aug 2009 10:12:58 +0200 Message-Id: <1249632778.32113.608.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2009-08-07 at 07:11 +0200, Frederic Weisbecker wrote: > The callchain fractal mode builds each new total hits in a new branch > of profiling by using the parent's hits of the current branch plus the > hits of the children. > > This is wrong, the total hits of a branch should be made of the sum of > every children hits, we must ignore the parent hits in this scope. > > This patch also fixes another mistakes with the hit counting. > > Now the rates are corrects. > > Signed-off-by: Frederic Weisbecker > Cc: Peter Zijlstra > Cc: Arnaldo Carvalho de Melo > Cc: Peter Zijlstra > Cc: Mike Galbraith > --- Ah will this fix these instances where you'd have things like | page_fault | | | |--100.00%-- __strcmp_sse2 | | copy_dep_chain | | __libc_start_main | | | --100.00%-- gettimeofday | __libc_start_main I was meaning to poke you about that :-)