From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbZHITyq (ORCPT ); Sun, 9 Aug 2009 15:54:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753466AbZHITyp (ORCPT ); Sun, 9 Aug 2009 15:54:45 -0400 Received: from mail-qy0-f196.google.com ([209.85.221.196]:45798 "EHLO mail-qy0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753247AbZHITyn (ORCPT ); Sun, 9 Aug 2009 15:54:43 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=gX281GioA1klJ1rA/lMv3V41DUlha8+lsYdrwh7wCeMnbkMBrv3IXWdIhvNe2+MaEe MOvEBItFqWoX4pwvN82EagEyXU+9i32w3v3ScUdRS2tCwe4FI+nCtxc1TlDCLXBE+mPj ZXYKHVKpkqwB2ZOhmmcAYO4AyEeNuVVk1mb5k= From: Marcin Slusarz To: LKML Cc: Jens Axboe , Tim Waugh Subject: [PATCH 07/14] block: use printk_once Date: Sun, 9 Aug 2009 21:54:02 +0200 Message-Id: <1249847649-11631-8-git-send-email-marcin.slusarz@gmail.com> X-Mailer: git-send-email 1.6.3.3 In-Reply-To: <1249847649-11631-1-git-send-email-marcin.slusarz@gmail.com> References: <1249847649-11631-1-git-send-email-marcin.slusarz@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Marcin Slusarz Cc: Jens Axboe Cc: Tim Waugh --- drivers/block/paride/pcd.c | 12 ++++-------- drivers/block/sx8.c | 4 +--- drivers/block/viodasd.c | 12 +++--------- 3 files changed, 8 insertions(+), 20 deletions(-) diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c index 911dfd9..9f3518c 100644 --- a/drivers/block/paride/pcd.c +++ b/drivers/block/paride/pcd.c @@ -219,8 +219,6 @@ static int pcd_sector; /* address of next requested sector */ static int pcd_count; /* number of blocks still to do */ static char *pcd_buf; /* buffer for request in progress */ -static int pcd_warned; /* Have we logged a phase warning ? */ - /* kernel glue structures */ static int pcd_block_open(struct block_device *bdev, fmode_t mode) @@ -417,12 +415,10 @@ static int pcd_completion(struct pcd_unit *cd, char *buf, char *fun) printk ("%s: %s: Unexpected phase %d, d=%d, k=%d\n", cd->name, fun, p, d, k); - if ((verbose < 2) && !pcd_warned) { - pcd_warned = 1; - printk - ("%s: WARNING: ATAPI phase errors\n", - cd->name); - } + if (verbose < 2) + printk_once( + "%s: WARNING: ATAPI phase errors\n", + cd->name); mdelay(1); } if (k++ > PCD_TMO) { diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c index da403b6..f5cd2e8 100644 --- a/drivers/block/sx8.c +++ b/drivers/block/sx8.c @@ -1564,15 +1564,13 @@ static int carm_init_shm(struct carm_host *host) static int carm_init_one (struct pci_dev *pdev, const struct pci_device_id *ent) { - static unsigned int printed_version; struct carm_host *host; unsigned int pci_dac; int rc; struct request_queue *q; unsigned int i; - if (!printed_version++) - printk(KERN_DEBUG DRV_NAME " version " DRV_VERSION "\n"); + printk_once(KERN_DEBUG DRV_NAME " version " DRV_VERSION "\n"); rc = pci_enable_device(pdev); if (rc) diff --git a/drivers/block/viodasd.c b/drivers/block/viodasd.c index 390d69b..b441ce3 100644 --- a/drivers/block/viodasd.c +++ b/drivers/block/viodasd.c @@ -416,15 +416,9 @@ retry: goto retry; } if (we.max_disk > (MAX_DISKNO - 1)) { - static int warned; - - if (warned == 0) { - warned++; - printk(VIOD_KERN_INFO - "Only examining the first %d " - "of %d disks connected\n", - MAX_DISKNO, we.max_disk + 1); - } + printk_once(VIOD_KERN_INFO + "Only examining the first %d of %d disks connected\n", + MAX_DISKNO, we.max_disk + 1); } /* Send the close event to OS/400. We DON'T expect a response */ -- 1.6.3.3