From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755567AbZHJQDN (ORCPT ); Mon, 10 Aug 2009 12:03:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755510AbZHJQDN (ORCPT ); Mon, 10 Aug 2009 12:03:13 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:53353 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755438AbZHJQDL (ORCPT ); Mon, 10 Aug 2009 12:03:11 -0400 Subject: Re: [PATCH 1/3] SCSI: Allow platform-specific code to be run against the SCSI tree From: James Bottomley To: Matthew Garrett Cc: linux-acpi@vger.kernel.org, linux-scsi@vger.kernel.org, shaohua.li@intel.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20090810145809.GD24956@srcf.ucam.org> References: <1247518987-10818-1-git-send-email-mjg@redhat.com> <20090810133815.GB22763@srcf.ucam.org> <1249916125.4089.4.camel@mulgrave.site> <20090810145809.GD24956@srcf.ucam.org> Content-Type: text/plain Date: Mon, 10 Aug 2009 11:03:07 -0500 Message-Id: <1249920187.4089.129.camel@mulgrave.site> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2009-08-10 at 15:58 +0100, Matthew Garrett wrote: > On Mon, Aug 10, 2009 at 02:55:25PM +0000, James Bottomley wrote: > > On Mon, 2009-08-10 at 14:38 +0100, Matthew Garrett wrote: > > > On Mon, Jul 13, 2009 at 10:03:05PM +0100, Matthew Garrett wrote: > > > > In certain cases (such as ACPI) we want to be able to associate > > > > platform-specific data against the SCSI device tree. Handling this > > > > properly requires the ability to run platform code at SCSI init time. > > > > This patch adds stub functions that can be overridden if the platform > > > > defines CONFIG_SCSI_PLATFORM. > > > > > > James, any thoughts on this? > > > > Sorry, I'd thought this had all moved to libata so I'd stopped paying > > attention ... why are extra bits in SCSI necessary? > > They're SCSI as far as the device tree is concerned, so the glue > callbacks have to be registered from the SCSI layer. The only > implementation so far is for ACPI and only covers libata, but it could > potentially also be used to tie bay devices to the ofw tree on > openfirmware systems. It's hard for me to comment without seeing the scsi_platform_register code, but it strikes me that the only SCSI piece it's using is the scsi_bus ... what else is SCSI specific in there? James