From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 09/11] staging: rtl8192e: Remove unused variable is_silent_reset
Date: Sun, 1 Oct 2023 15:45:13 +0200 [thread overview]
Message-ID: <124d8f91db347e0e35184b356ba4ec39f52871cb.1696165351.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1696165351.git.philipp.g.hortmann@gmail.com>
ieee->is_silent_reset is set to false and never changed. All
equations result accordingly. Remove dead code.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8192e/rtllib.h | 1 -
drivers/staging/rtl8192e/rtllib_softmac.c | 10 ++--------
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index aa198983cb3c..004818520ea8 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1211,7 +1211,6 @@ struct rtllib_device {
bool bForcedBgMode;
u8 hwsec_active;
- bool is_silent_reset;
bool is_roaming;
bool ieee_up;
bool cannot_notify;
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 72d0225dfdf1..777338fd2664 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -1298,10 +1298,8 @@ static void rtllib_associate_complete_wq(void *data)
netdev_info(ieee->dev, "Associated successfully with %pM\n",
ieee->current_network.bssid);
- if (!ieee->is_silent_reset) {
- netdev_info(ieee->dev, "normal associate\n");
- notify_wx_assoc_event(ieee);
- }
+ netdev_info(ieee->dev, "normal associate\n");
+ notify_wx_assoc_event(ieee);
netif_carrier_on(ieee->dev);
ieee->is_roaming = false;
@@ -1334,10 +1332,6 @@ static void rtllib_associate_complete_wq(void *data)
psc->LpsIdleCount = 0;
ieee->link_change(ieee->dev);
- if (ieee->is_silent_reset) {
- netdev_info(ieee->dev, "silent reset associate\n");
- ieee->is_silent_reset = false;
- }
}
static void rtllib_sta_send_associnfo(struct rtllib_device *ieee)
--
2.42.0
next prev parent reply other threads:[~2023-10-01 13:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 13:43 [PATCH 00/11] staging: rtl8192e: Remove broken function _rtl92e_if_silent_reset() Philipp Hortmann
2023-10-01 13:43 ` [PATCH 01/11] staging: rtl8192e: Remove ibss_maxjoin_chal Philipp Hortmann
2023-10-01 13:44 ` [PATCH 02/11] staging: rtl8192e: Remove dead code from _rtl92e_if_check_reset() Philipp Hortmann
2023-10-01 13:44 ` [PATCH 03/11] staging: rtl8192e: Remove RESET_TYPE_NORMAL Philipp Hortmann
2023-10-01 13:44 ` [PATCH 04/11] staging: rtl8192e: Remove broken function _rtl92e_if_silent_reset() Philipp Hortmann
2023-10-01 13:44 ` [PATCH 05/11] staging: rtl8192e: Remove unused variable rst_progress Philipp Hortmann
2023-10-01 13:44 ` [PATCH 06/11] staging: rtl8192e: Remove unused variable reset_in_progress Philipp Hortmann
2023-10-01 13:44 ` [PATCH 07/11] staging: rtl8192e: Remove unused parameter from _rtl92e_sta_up() Philipp Hortmann
2023-10-01 13:45 ` [PATCH 08/11] staging: rtl8192e: Remove unused parameter from _rtl92e_up() Philipp Hortmann
2023-10-01 13:45 ` Philipp Hortmann [this message]
2023-10-01 13:45 ` [PATCH 10/11] staging: rtl8192e: Remove unused variables priv->reset_count and reset_cnt Philipp Hortmann
2023-10-01 13:45 ` [PATCH 11/11] staging: rtl8192e: Remove r8192_private_handler _rtl92e_wx_force_reset() Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=124d8f91db347e0e35184b356ba4ec39f52871cb.1696165351.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®