From: Mark Brown <broonie@kernel.org>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: andriy.shevchenko@linux.intel.com, lgirdwood@gmail.com,
perex@perex.cz, pierre-louis.bossart@linux.intel.com,
13916275206@139.com, zhourui@huaqin.com,
alsa-devel@alsa-project.org, i-salazar@ti.com,
linux-kernel@vger.kernel.org, j-chadha@ti.com,
liam.r.girdwood@intel.com, jaden-yue@ti.com,
yung-chuan.liao@linux.intel.com, dipa@ti.com, yuhsuan@google.com,
henry.lo@ti.com, tiwai@suse.de, baojun.xu@ti.com, soyer@irl.hu,
Baojun.Xu@fpt.com, judyhsiao@google.com, navada@ti.com,
cujomalainey@google.com, aanya@ti.com, nayeem.mahmud@ti.com,
savyasanchi.shukla@netradyne.com, flaviopr@microsoft.com,
jesse-ji@ti.com, darren.ye@mediatek.com
Subject: Re: [PATCH v1 1/2] ASoc: tas2781: Add TAS2563 into the Header
Date: Mon, 15 Jul 2024 19:12:12 +0100 [thread overview]
Message-ID: <124ded12-330c-4a4a-814e-2dbf1b9b7ca3@sirena.org.uk> (raw)
In-Reply-To: <20240713015145.314-1-shenghao-ding@ti.com>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
On Sat, Jul 13, 2024 at 09:51:41AM +0800, Shenghao Ding wrote:
> Add TAS2563 into the Header in case of misunderstanding.
> @@ -64,8 +64,8 @@ static int tasdevice_change_chn_book(struct tasdevice_priv *tas_priv,
> */
> ret = regmap_write(map, TASDEVICE_PAGE_SELECT, 0);
> if (ret < 0) {
> - dev_err(tas_priv->dev, "%s, E=%d\n",
> - __func__, ret);
> + dev_err(tas_priv->dev, "%s, E=%d channel:%d\n",
> + __func__, ret, chn);
> goto out;
> }
This is reasonable enough but doesn't match the changelog.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-07-15 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-13 1:51 Shenghao Ding
2024-07-13 1:51 ` [PATCH v1 2/2] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781 Shenghao Ding
2024-07-15 18:17 ` Mark Brown
2024-07-15 18:12 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=124ded12-330c-4a4a-814e-2dbf1b9b7ca3@sirena.org.uk \
--to=broonie@kernel.org \
--cc=13916275206@139.com \
--cc=Baojun.Xu@fpt.com \
--cc=aanya@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=cujomalainey@google.com \
--cc=darren.ye@mediatek.com \
--cc=dipa@ti.com \
--cc=flaviopr@microsoft.com \
--cc=henry.lo@ti.com \
--cc=i-salazar@ti.com \
--cc=j-chadha@ti.com \
--cc=jaden-yue@ti.com \
--cc=jesse-ji@ti.com \
--cc=judyhsiao@google.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=nayeem.mahmud@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=savyasanchi.shukla@netradyne.com \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
--cc=yuhsuan@google.com \
--cc=yung-chuan.liao@linux.intel.com \
--cc=zhourui@huaqin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®