From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0B7C4CEC4 for ; Sun, 15 Sep 2019 23:52:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52B7220692 for ; Sun, 15 Sep 2019 23:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568591551; bh=YwRxJ3GfNVBgv9H7aquBPh28Xgd9p7TE3U/8NkNv3RQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=WQ3YRZAKnz58ZuJ49I4PgIkQ9mxuYbX67F59QskwI2geocfJnmB3r7UJj5lk9koPw JwyQHUoqwR8PteLAZCeguPfFNrfrI0xJnrZCoiTT2rvRr2GLZBxaE/bMBb2DeinvOR yYkjuWIz9977WxDQhjro9U3n6QkT22bceig4KrYo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726944AbfIOXwa (ORCPT ); Sun, 15 Sep 2019 19:52:30 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:35524 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726502AbfIOXwa (ORCPT ); Sun, 15 Sep 2019 19:52:30 -0400 Received: by mail-io1-f67.google.com with SMTP id q10so2831320iop.2 for ; Sun, 15 Sep 2019 16:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OMEng1dD6mbfK8lrN505N4uVQ1mgym5lt3dseXptiRU=; b=Ez08UaTY15c4Ih7ylIrfCET1PvR8hL84h6rlrrfa4tb9/nLxFka/MOmH8xulAXgGFO pfd59Zuh2pmu+/Ak9BWEuS6qTgPJD+/+Fcr50of6+XRyw4gDskSqC+/YI+jpWScyQBaF ncxLpX+3KAsP+C3AJNBcgy3Ky6DsZkfqfo7VE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OMEng1dD6mbfK8lrN505N4uVQ1mgym5lt3dseXptiRU=; b=o7vr/OZhrR4CSRFzBA6hY0hwLz5j91PtF5zJj5Fd4OvAkT7+w1fC/FC4b+MsEOCowN 5l7JkqLJ2QNo0j/7S+tv+inlEQDCsQzr9hybXN2GioCh4K6i5Tlfc1xmy3sR8vanouND amK91w9LQccoA1Q1bzDCcSngDlV0jQo+K+R7PtH0SBxjtuiL2MGD81ImoRYujYaAOJCv WNn3Fh7gRhRWSSX5+YwdWry+HlDKxhyGrmYC4kvHxQkhLdli5fis4Os4YN6CJesw29Oa zlh7DLyOwxW0MUEGqlwuug2wwzZplmRrbdPU2V0GTx07dJaTfB/FMjeSKUTqMs80dBkd m0oA== X-Gm-Message-State: APjAAAXEtcLkJyEMO+82h8i33fWaDUkfiKB2jLubD7CIdCIhRab5Rlwn 49XgtGPNavD3s4J6B2d8h93QxQ== X-Google-Smtp-Source: APXvYqy4Dq00Lwww63fO8cWIOl3thAdOe56DRE7CvMS/exs+R+1tGCmp247IAN5yAZIA0MnroamoWA== X-Received: by 2002:a5d:814d:: with SMTP id f13mr13472419ioo.162.1568591549261; Sun, 15 Sep 2019 16:52:29 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id w22sm14670354ior.79.2019.09.15.16.52.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Sep 2019 16:52:28 -0700 (PDT) Subject: Re: [PATCH v4 3/5] vimc: move duplicated IS_SRC and IS_SINK to common header To: Helen Koike , mchehab@kernel.org, andrealmeid@collabora.com, dafna.hirschfeld@collabora.com, hverkuil-cisco@xs4all.nl Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <8dbc93c2a7291d942d2d37491833444d77316211.1567822793.git.skhan@linuxfoundation.org> From: Shuah Khan Message-ID: <124fe9af-5540-770e-d124-99e2b3b4e39a@linuxfoundation.org> Date: Sun, 15 Sep 2019 17:52:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/15/19 1:25 PM, Helen Koike wrote: > Hi Shuah, > > On 9/6/19 11:42 PM, Shuah Khan wrote: >> Move duplicated IS_SRC and IS_SINK dfines to common header. Rename >> them to VIMC_IS_SRC and VIM_IS_SINK. >> >> Signed-off-by: Shuah Khan >> --- >> drivers/media/platform/vimc/vimc-common.h | 4 ++++ >> drivers/media/platform/vimc/vimc-debayer.c | 11 ++++------- >> drivers/media/platform/vimc/vimc-scaler.c | 8 +++----- >> 3 files changed, 11 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/media/platform/vimc/vimc-common.h b/drivers/media/platform/vimc/vimc-common.h >> index 87ee84f78322..236412ad7548 100644 >> --- a/drivers/media/platform/vimc/vimc-common.h >> +++ b/drivers/media/platform/vimc/vimc-common.h >> @@ -27,6 +27,10 @@ >> >> #define VIMC_FRAME_INDEX(lin, col, width, bpp) ((lin * width + col) * bpp) >> >> +/* Source and sink pad checks */ >> +#define VIMC_IS_SRC(pad) (pad) >> +#define VIMC_IS_SINK(pad) (!(pad)) > > This is true now, but it might not be true in the future. > In the output video device (that was sent by André but not yet upstream) for instance, only have a single > source pad (which I suppose the index will be 0), and this macro won't be true. > > Maybe we could check pad flags in sd->entity->pads[index].flags ? > I think this change should be done in André's patch? thanks, -- Shuah