From: Florian Fainelli <f.fainelli@gmail.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Egil Hjelmeland <privat@egil-hjelmeland.no>,
andrew@lunn.ch, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly
Date: Fri, 28 Jul 2017 10:05:06 -0700 [thread overview]
Message-ID: <1250382a-1c17-8e82-8c5c-fe14786c84db@gmail.com> (raw)
In-Reply-To: <87fudgqz4w.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
On 07/28/2017 09:55 AM, Vivien Didelot wrote:
> Hi Egil,
>
> Egil Hjelmeland <privat@egil-hjelmeland.no> writes:
>
>>>> +const struct lan9303_phy_ops lan9303_indirect_phy_ops = {
>>>> + .phy_read = lan9303_indirect_phy_read,
>>>> + .phy_write = lan9303_indirect_phy_write,
>>>> +};
>>>> +EXPORT_SYMBOL(lan9303_indirect_phy_ops);
>>>
>>> Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL?
>>
>> I have no opinion. I just used the same variant as the other EXPORTS
>> in the file.
>
> If there is no concern from others about this, LGTM too:
Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem
to be appropriate, which can be done as a subsequent patch.
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2017-07-28 17:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 15:11 [PATCH net-next 0/4] net: dsa: lan9303: Fix MDIO issues Egil Hjelmeland
2017-07-28 15:11 ` [PATCH net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO Egil Hjelmeland
2017-07-28 15:19 ` Andrew Lunn
2017-07-28 15:36 ` Vivien Didelot
2017-07-28 17:02 ` Florian Fainelli
2017-07-28 15:11 ` [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register Egil Hjelmeland
2017-07-28 15:20 ` Andrew Lunn
2017-07-28 15:37 ` Vivien Didelot
2017-07-28 17:02 ` Florian Fainelli
2017-07-28 15:11 ` [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions Egil Hjelmeland
2017-07-28 15:22 ` Andrew Lunn
2017-07-28 15:37 ` Vivien Didelot
2017-07-28 17:03 ` Florian Fainelli
2017-07-28 15:11 ` [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Egil Hjelmeland
2017-07-28 15:24 ` Andrew Lunn
2017-07-28 15:39 ` Vivien Didelot
2017-07-28 16:24 ` Egil Hjelmeland
2017-07-28 16:55 ` Vivien Didelot
2017-07-28 17:05 ` Florian Fainelli [this message]
2017-07-28 19:44 ` Egil Hjelmeland
2017-07-28 21:28 ` Andrew Lunn
2017-07-28 22:30 ` Egil Hjelmeland
2017-07-31 11:44 ` David Laight
2017-07-28 15:24 ` [PATCH net-next 0/4] net: dsa: lan9303: Fix MDIO issues Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250382a-1c17-8e82-8c5c-fe14786c84db@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=privat@egil-hjelmeland.no \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®