From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Steve French <sfrench@us.ibm.com>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Roman Zippel <zippel@linux-m68k.org>,
Petr Vandrovec <vandrove@vc.cvut.cz>,
Anton Altaparmakov <aia21@cantab.net>
Subject: Re: [patch] fs: Make unload_nls() NULL pointer safe
Date: Mon, 17 Aug 2009 07:40:06 -0500 [thread overview]
Message-ID: <1250512806.24927.8.camel@norville.austin.ibm.com> (raw)
In-Reply-To: <20090816210335.309469111@linutronix.de>
On Sun, 2009-08-16 at 21:05 +0000, Thomas Gleixner wrote:
> plain text document attachment (unload_nls.patch)
> Most call sites of unload_nls() do:
> if (nls)
> unload_nls(nls);
>
> Check the pointer inside unload_nls() like we do in kfree() and
> simplify the call sites.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Steve French <sfrench@us.ibm.com>
> Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> Cc: Roman Zippel <zippel@linux-m68k.org>
Acked-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
> Cc: Petr Vandrovec <vandrove@vc.cvut.cz>
> Cc: Anton Altaparmakov <aia21@cantab.net>
>
> ---
> fs/befs/linuxvfs.c | 7 +------
> fs/cifs/cifsfs.c | 3 +--
> fs/fat/inode.c | 16 ++++------------
> fs/hfs/mdb.c | 6 ++----
> fs/hfsplus/super.c | 6 ++----
> fs/isofs/inode.c | 8 ++------
> fs/jfs/super.c | 9 +++------
> fs/ncpfs/inode.c | 12 ++----------
> fs/ncpfs/ioctl.c | 6 ++----
> fs/nls/nls_base.c | 3 ++-
> fs/ntfs/super.c | 10 ++++------
> fs/smbfs/inode.c | 10 ++--------
> 12 files changed, 27 insertions(+), 69 deletions(-)
--
David Kleikamp
IBM Linux Technology Center
prev parent reply other threads:[~2009-08-17 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-16 21:05 Thomas Gleixner
2009-08-17 12:40 ` Dave Kleikamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250512806.24927.8.camel@norville.austin.ibm.com \
--to=shaggy@linux.vnet.ibm.com \
--cc=aia21@cantab.net \
--cc=hch@infradead.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@us.ibm.com \
--cc=tglx@linutronix.de \
--cc=vandrove@vc.cvut.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®