From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: William Cohen <wcohen@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add minimal support for software performance counters for ia64
Date: Wed, 19 Aug 2009 21:06:59 +0200 [thread overview]
Message-ID: <1250708819.7154.5.camel@laptop> (raw)
In-Reply-To: <4A8C4CAA.5070101@redhat.com>
On Wed, 2009-08-19 at 15:04 -0400, William Cohen wrote:
> Peter Zijlstra wrote:
> > On Wed, 2009-08-19 at 12:04 -0400, William Cohen wrote:
> >> +#ifdef __ia64__
> >> +#include "../../arch/ia64/include/asm/unistd.h"
> >> +#define rmb() asm volatile("" ::: "memory")
> >> +#define cpu_relax() asm volatile("" ::: "memory");
> >> +#endif
> >
> > Surely the itanic has a real memory barrier? The kernel seems to use
> > something along the lines of mf.
> >
> > Also, cpu_relax() seems to end up being asm volatile("hint @pause" :::
> > "memory"), although we don't seem to have an actual user of cpu_relax()
> > in perf atm.
> >
> >
> >
>
> Peter, thanks for the comment. I took a look at the rmb() and cpu_relax() code
> in the kernel and revised the patch with the appropriate defines
Looks good now, thanks!
next prev parent reply other threads:[~2009-08-19 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 16:04 William Cohen
2009-08-19 16:12 ` Peter Zijlstra
2009-08-19 19:04 ` William Cohen
2009-08-19 19:06 ` Peter Zijlstra [this message]
2009-08-20 21:19 ` William Cohen
2009-08-21 14:25 ` Ingo Molnar
2009-08-21 15:09 ` William Cohen
2009-08-21 16:37 ` [PATCH, V2] perf_counter, IA64: Add support for software performance counters Ingo Molnar
2009-08-19 16:12 ` [PATCH] Add minimal support for software performance counters for ia64 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250708819.7154.5.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=wcohen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome