mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Yangtao Li <frank.li@vivo.com>,
	Derek Kiernan <derek.kiernan@amd.com>,
	Dragan Cvetic <dragan.cvetic@amd.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] misc/xilinx_sdfec: Convert to devm_platform_ioremap_resource()
Date: Fri, 7 Jul 2023 08:21:32 +0200	[thread overview]
Message-ID: <1250788a-bae0-adea-0b5e-ce7cc39ff79a@amd.com> (raw)
In-Reply-To: <20230707024224.78907-2-frank.li@vivo.com>



On 7/7/23 04:42, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>   drivers/misc/xilinx_sdfec.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> index 270ff4c5971a..0877c42fb8e7 100644
> --- a/drivers/misc/xilinx_sdfec.c
> +++ b/drivers/misc/xilinx_sdfec.c
> @@ -1347,7 +1347,6 @@ static int xsdfec_probe(struct platform_device *pdev)
>   {
>   	struct xsdfec_dev *xsdfec;
>   	struct device *dev;
> -	struct resource *res;
>   	int err;
>   	bool irq_enabled = true;
>   
> @@ -1363,8 +1362,7 @@ static int xsdfec_probe(struct platform_device *pdev)
>   		return err;
>   
>   	dev = xsdfec->dev;
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	xsdfec->regs = devm_ioremap_resource(dev, res);
> +	xsdfec->regs = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(xsdfec->regs)) {
>   		err = PTR_ERR(xsdfec->regs);
>   		goto err_xsdfec_dev;

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
M

  reply	other threads:[~2023-07-07  6:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-07  2:42 [PATCH 1/3] misc: atmel-ssc: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-07  2:42 ` [PATCH 2/3] misc/xilinx_sdfec: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-07  6:21   ` Michal Simek [this message]
2023-07-07  2:42 ` [PATCH 3/3] misc: xilinx_tmr_manager: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-07  6:21   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250788a-bae0-adea-0b5e-ce7cc39ff79a@amd.com \
    --to=michal.simek@amd.com \
    --cc=arnd@arndb.de \
    --cc=derek.kiernan@amd.com \
    --cc=dragan.cvetic@amd.com \
    --cc=frank.li@vivo.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®