mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@canonical.com>
To: "Ed L. Cashin" <ecashin@coraid.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Whitcroft <apw@canonical.com>,
	linux-kernel@vger.kernel.org
Cc: Andy Whitcroft <apw@canonical.com>
Subject: [PATCH 0/1] aoe: ensure we initialise the request_queue correctly
Date: Fri, 21 Aug 2009 17:41:43 +0100	[thread overview]
Message-ID: <1250872904-10993-1-git-send-email-apw@canonical.com> (raw)

We have been seeing oopses in very recent kernels when using the AOE driver.
When attempting to mount remote devices we get a warning from the kobject
layer:

  [ 2645.959090] kobject '<NULL>' (ffff880059ca22c0): tried to add
	an uninitialized object, something is seriously wrong.

Looking at the driver it seems to have always had an embedded request_queue
and it is this that is throwing the error.  It appears the intent is
tha these would be allocated and released using helpers, and the lack of
these leaves the object uninitialised and throws the error.  It is unclear
how this could ever have worked.  Anyhow the following email contains a
patch to allocate and release this request_queue via the standard helpers.
This has bene shown to fix the issue in testing.

Comments.

-apw

Andy Whitcroft (1):
  aoe: ensure we initialise the request_queue correctly

 drivers/block/aoe/aoe.h    |    2 +-
 drivers/block/aoe/aoeblk.c |    6 +++---
 drivers/block/aoe/aoedev.c |   11 ++++++++++-
 3 files changed, 14 insertions(+), 5 deletions(-)


             reply	other threads:[~2009-08-21 16:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-21 16:41 Andy Whitcroft [this message]
2009-08-21 16:41 ` [PATCH 1/1] " Andy Whitcroft
2009-08-21 18:58 ` [PATCH 0/1] " Ed Cashin
2009-08-22  9:21 ` Bruno Prémont
2009-08-22 21:52   ` Rafael J. Wysocki
2009-08-23  9:00     ` Bruno Prémont
2009-08-23 20:16       ` Bruno Prémont
2009-08-24 14:27 ` Ed Cashin
2009-08-29 13:43   ` Bruno Prémont
2009-09-01 19:15     ` Ed Cashin
2009-09-01 20:31       ` Bruno Prémont
2009-09-02 13:31         ` Ed Cashin
2009-09-02 19:55       ` Andrew Morton
2009-09-02 20:16         ` Ed Cashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250872904-10993-1-git-send-email-apw@canonical.com \
    --to=apw@canonical.com \
    --cc=akpm@linux-foundation.org \
    --cc=ecashin@coraid.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®