From: Josh Stone <jistone@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Josh Stone <jistone@redhat.com>, Jason Baron <jbaron@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Li Zefan <lizf@cn.fujitsu.com>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Jiaying Zhang <jiayingz@google.com>,
Martin Bligh <mbligh@google.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: [PATCH v3 2/4] tracing: Make syscall_(un)regfunc arch-specific
Date: Fri, 21 Aug 2009 21:58:43 -0700 [thread overview]
Message-ID: <1250917125-6174-3-git-send-email-jistone@redhat.com> (raw)
In-Reply-To: <1250917125-6174-2-git-send-email-jistone@redhat.com>
The bodies of syscall_regfunc and syscall_unregfunc need the
arch-specific flag TIF_SYSCALL_TRACEPOINT, which only exists
on x86 and s390, so they should live in arch-specific files.
Signed-off-by: Josh Stone <jistone@redhat.com>
Cc: Jason Baron <jbaron@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Jiaying Zhang <jiayingz@google.com>
Cc: Martin Bligh <mbligh@google.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
---
arch/s390/kernel/ptrace.c | 40 ++++++++++++++++++++++++++++++++++++++++
arch/x86/kernel/ptrace.c | 40 ++++++++++++++++++++++++++++++++++++++++
kernel/tracepoint.c | 40 ----------------------------------------
3 files changed, 80 insertions(+), 40 deletions(-)
diff --git a/arch/s390/kernel/ptrace.c b/arch/s390/kernel/ptrace.c
index 9d3dcfa..b6dcd72 100644
--- a/arch/s390/kernel/ptrace.c
+++ b/arch/s390/kernel/ptrace.c
@@ -925,3 +925,43 @@ const struct user_regset_view *task_user_regset_view(struct task_struct *task)
#endif
return &user_s390_view;
}
+
+#ifdef CONFIG_TRACEPOINTS
+
+static DEFINE_MUTEX(regfunc_mutex);
+static int sys_tracepoint_refcount;
+
+void syscall_regfunc(void)
+{
+ unsigned long flags;
+ struct task_struct *g, *t;
+
+ mutex_lock(®func_mutex);
+ if (!sys_tracepoint_refcount) {
+ read_lock_irqsave(&tasklist_lock, flags);
+ do_each_thread(g, t) {
+ set_tsk_thread_flag(t, TIF_SYSCALL_TRACEPOINT);
+ } while_each_thread(g, t);
+ read_unlock_irqrestore(&tasklist_lock, flags);
+ }
+ sys_tracepoint_refcount++;
+ mutex_unlock(®func_mutex);
+}
+
+void syscall_unregfunc(void)
+{
+ unsigned long flags;
+ struct task_struct *g, *t;
+
+ mutex_lock(®func_mutex);
+ sys_tracepoint_refcount--;
+ if (!sys_tracepoint_refcount) {
+ read_lock_irqsave(&tasklist_lock, flags);
+ do_each_thread(g, t) {
+ clear_tsk_thread_flag(t, TIF_SYSCALL_TRACEPOINT);
+ } while_each_thread(g, t);
+ read_unlock_irqrestore(&tasklist_lock, flags);
+ }
+ mutex_unlock(®func_mutex);
+}
+#endif
diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index a909afe..c2adbed 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -1549,3 +1549,43 @@ asmregparm void syscall_trace_leave(struct pt_regs *regs)
tracehook_consider_fatal_signal(current, SIGTRAP))
send_sigtrap(current, regs, 0, TRAP_BRKPT);
}
+
+#ifdef CONFIG_TRACEPOINTS
+
+static DEFINE_MUTEX(regfunc_mutex);
+static int sys_tracepoint_refcount;
+
+void syscall_regfunc(void)
+{
+ unsigned long flags;
+ struct task_struct *g, *t;
+
+ mutex_lock(®func_mutex);
+ if (!sys_tracepoint_refcount) {
+ read_lock_irqsave(&tasklist_lock, flags);
+ do_each_thread(g, t) {
+ set_tsk_thread_flag(t, TIF_SYSCALL_TRACEPOINT);
+ } while_each_thread(g, t);
+ read_unlock_irqrestore(&tasklist_lock, flags);
+ }
+ sys_tracepoint_refcount++;
+ mutex_unlock(®func_mutex);
+}
+
+void syscall_unregfunc(void)
+{
+ unsigned long flags;
+ struct task_struct *g, *t;
+
+ mutex_lock(®func_mutex);
+ sys_tracepoint_refcount--;
+ if (!sys_tracepoint_refcount) {
+ read_lock_irqsave(&tasklist_lock, flags);
+ do_each_thread(g, t) {
+ clear_tsk_thread_flag(t, TIF_SYSCALL_TRACEPOINT);
+ } while_each_thread(g, t);
+ read_unlock_irqrestore(&tasklist_lock, flags);
+ }
+ mutex_unlock(®func_mutex);
+}
+#endif
diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
index 43bca1f..2ce4d38 100644
--- a/kernel/tracepoint.c
+++ b/kernel/tracepoint.c
@@ -578,43 +578,3 @@ static int init_tracepoints(void)
__initcall(init_tracepoints);
#endif /* CONFIG_MODULES */
-
-#ifdef CONFIG_FTRACE_SYSCALLS
-
-static DEFINE_MUTEX(regfunc_mutex);
-static int sys_tracepoint_refcount;
-
-void syscall_regfunc(void)
-{
- unsigned long flags;
- struct task_struct *g, *t;
-
- mutex_lock(®func_mutex);
- if (!sys_tracepoint_refcount) {
- read_lock_irqsave(&tasklist_lock, flags);
- do_each_thread(g, t) {
- set_tsk_thread_flag(t, TIF_SYSCALL_TRACEPOINT);
- } while_each_thread(g, t);
- read_unlock_irqrestore(&tasklist_lock, flags);
- }
- sys_tracepoint_refcount++;
- mutex_unlock(®func_mutex);
-}
-
-void syscall_unregfunc(void)
-{
- unsigned long flags;
- struct task_struct *g, *t;
-
- mutex_lock(®func_mutex);
- sys_tracepoint_refcount--;
- if (!sys_tracepoint_refcount) {
- read_lock_irqsave(&tasklist_lock, flags);
- do_each_thread(g, t) {
- clear_tsk_thread_flag(t, TIF_SYSCALL_TRACEPOINT);
- } while_each_thread(g, t);
- read_unlock_irqrestore(&tasklist_lock, flags);
- }
- mutex_unlock(®func_mutex);
-}
-#endif
--
1.6.2.5
next prev parent reply other threads:[~2009-08-22 4:59 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 7:23 [PATCH] tracing: Move tracepoint callbacks into DEFINE Josh Stone
2009-08-18 14:19 ` Jason Baron
2009-08-18 22:11 ` Josh Stone
2009-08-18 22:25 ` [PATCH] tracing: Create generic syscall TRACE_EVENTs Josh Stone
2009-08-19 1:32 ` Li Zefan
2009-08-19 3:05 ` Josh Stone
2009-08-19 13:05 ` Ingo Molnar
2009-08-19 13:50 ` Mathieu Desnoyers
2009-08-19 16:16 ` Jason Baron
2009-08-19 17:43 ` Frederic Weisbecker
2009-08-19 16:13 ` [PATCH] tracing: Move tracepoint callbacks into DEFINE Jason Baron
2009-08-20 17:25 ` Josh Stone
2009-08-20 19:09 ` [PATCH v2 1/2] " Josh Stone
2009-08-20 19:09 ` [PATCH v2 2/2] tracing: Create generic syscall TRACE_EVENTs Josh Stone
2009-08-21 17:57 ` Jason Baron
2009-08-21 19:37 ` Josh Stone
2009-08-21 20:08 ` Jason Baron
2009-08-21 14:47 ` [PATCH v2 1/2] tracing: Move tracepoint callbacks into DEFINE Ingo Molnar
2009-08-21 19:34 ` Josh Stone
2009-08-21 17:52 ` Jason Baron
2009-08-21 19:34 ` Josh Stone
2009-08-21 20:06 ` Jason Baron
2009-08-23 20:29 ` Frederic Weisbecker
2009-08-23 20:15 ` Frederic Weisbecker
2009-08-22 4:58 ` [PATCH v3 0/4] tracing: tweaks for generic syscall events Josh Stone
2009-08-22 4:58 ` [PATCH v3 1/4] tracing: Rename TIF_SYSCALL_FTRACE->_TRACEPOINT Josh Stone
2009-08-22 4:58 ` Josh Stone [this message]
2009-08-22 4:58 ` [PATCH v3 3/4] tracing: Move tracepoint callbacks into DEFINE Josh Stone
2009-08-22 4:58 ` [PATCH v3 4/4] tracing: Create generic syscall TRACE_EVENTs Josh Stone
2009-08-23 21:14 ` [PATCH v3 2/4] tracing: Make syscall_(un)regfunc arch-specific Frederic Weisbecker
2009-08-24 1:40 ` Paul Mundt
2009-08-24 8:41 ` Ingo Molnar
2009-08-24 8:59 ` Paul Mundt
2009-08-24 9:56 ` Ingo Molnar
2009-08-24 10:32 ` Paul Mundt
2009-08-24 11:00 ` Ingo Molnar
2009-08-24 11:15 ` Paul Mundt
2009-08-24 11:32 ` Ingo Molnar
2009-08-24 11:52 ` Ingo Molnar
2009-08-24 12:14 ` Peter Zijlstra
2009-08-24 11:01 ` Ingo Molnar
2009-08-24 11:02 ` Paul Mundt
2009-08-24 19:31 ` Josh Stone
2009-08-24 19:58 ` Frederic Weisbecker
2009-08-24 20:00 ` Josh Stone
2009-08-24 20:12 ` Frederic Weisbecker
2009-08-23 21:16 ` [PATCH v3 1/4] tracing: Rename TIF_SYSCALL_FTRACE->_TRACEPOINT Frederic Weisbecker
2009-08-24 8:42 ` Ingo Molnar
2009-08-24 11:11 ` Frederic Weisbecker
2009-08-24 11:24 ` Ingo Molnar
2009-08-24 11:29 ` Paul Mundt
2009-08-24 11:36 ` Ingo Molnar
2009-08-24 21:43 ` [PATCH v4 0/4] tracing: tweaks for generic syscall events Josh Stone
2009-08-24 21:43 ` [PATCH v4 1/4] tracing: Rename FTRACE_SYSCALLS for tracepoints Josh Stone
2009-08-24 21:43 ` [PATCH v4 2/4] tracing: Make syscall tracepoints conditional Josh Stone
2009-08-24 21:43 ` [PATCH v4 3/4] tracing: Move tracepoint callbacks into DEFINE Josh Stone
2009-08-24 21:43 ` [PATCH v4 4/4] tracing: Create generic syscall TRACE_EVENTs Josh Stone
2009-08-26 7:22 ` [tip:tracing/core] " tip-bot for Josh Stone
2009-08-26 7:22 ` [tip:tracing/core] tracing: Move tracepoint callbacks from declaration to definition tip-bot for Josh Stone
2009-08-27 22:50 ` [PATCH] tracing: Fix double CPP substitution in TRACE_EVENT_FN Frederic Weisbecker
2009-08-28 0:38 ` Josh Stone
2009-08-28 12:29 ` [tip:tracing/core] " tip-bot for Frederic Weisbecker
2009-08-26 7:21 ` [tip:tracing/core] tracing: Make syscall tracepoints conditional tip-bot for Josh Stone
2009-08-26 7:21 ` [tip:tracing/core] tracing: Rename FTRACE_SYSCALLS for tracepoints tip-bot for Josh Stone
2009-08-24 23:05 ` [PATCH v4 0/4] tracing: tweaks for generic syscall events Frederic Weisbecker
2009-08-25 10:28 ` Ingo Molnar
2009-08-25 13:42 ` Frederic Weisbecker
2009-08-25 14:41 ` Jason Baron
2009-08-25 21:08 ` Frederic Weisbecker
2009-08-25 21:44 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250917125-6174-3-git-send-email-jistone@redhat.com \
--to=jistone@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jbaron@redhat.com \
--cc=jiayingz@google.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mbligh@google.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®