From: Jiri Slaby <jirislaby@gmail.com>
To: tiwai@suse.de
Cc: perex@perex.cz, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>
Subject: [PATCH 4/4] SOUND: wm8900, use uninitialized_var(fll_div)
Date: Tue, 25 Aug 2009 22:59:37 +0200 [thread overview]
Message-ID: <1251233977-5819-4-git-send-email-jirislaby@gmail.com> (raw)
In-Reply-To: <1251233977-5819-1-git-send-email-jirislaby@gmail.com>
To avoid a wrong compiler warning, use unitialized_var(fll_div) in
wm8900_set_fll.
If fll_div members are unitialized, we return before their use due to
error.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>
---
sound/soc/codecs/wm8900.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8900.c b/sound/soc/codecs/wm8900.c
index 5e9c855..255210a 100644
--- a/sound/soc/codecs/wm8900.c
+++ b/sound/soc/codecs/wm8900.c
@@ -747,7 +747,7 @@ static int wm8900_set_fll(struct snd_soc_codec *codec,
int fll_id, unsigned int freq_in, unsigned int freq_out)
{
struct wm8900_priv *wm8900 = codec->private_data;
- struct _fll_div fll_div;
+ struct _fll_div uninitialized_var(fll_div);
unsigned int reg;
if (wm8900->fll_in == freq_in && wm8900->fll_out == freq_out)
--
1.6.3.3
next prev parent reply other threads:[~2009-08-25 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 20:59 [PATCH 1/4] SOUND: atiixp, use uninitialized_var(chip) Jiri Slaby
2009-08-25 20:59 ` [PATCH 2/4] SOUND: serial-u16550, use unitialized_var(uart) Jiri Slaby
2009-08-25 20:59 ` [PATCH 3/4] SOUND: via82xx, use uninitialized_var(chip) Jiri Slaby
2009-08-25 20:59 ` Jiri Slaby [this message]
2009-08-26 7:12 ` [PATCH 1/4] SOUND: atiixp, " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251233977-5819-4-git-send-email-jirislaby@gmail.com \
--to=jirislaby@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®